[ALSA] fix resource leak in usbmixer
authorJesper Juhl <jesper.juhl@gmail.com>
Mon, 20 Mar 2006 10:27:13 +0000 (11:27 +0100)
committerJaroslav Kysela <perex@suse.cz>
Wed, 22 Mar 2006 09:39:28 +0000 (10:39 +0100)
Modules: USB generic driver

We may leak 'namelist' in sound/usb/usbmixer.c::parse_audio_selector_unit()

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/usbmixer.c

index 0bfea72..8d08b34 100644 (file)
@@ -1468,6 +1468,7 @@ static int parse_audio_selector_unit(struct mixer_build *state, int unitid, unsi
        kctl = snd_ctl_new1(&mixer_selectunit_ctl, cval);
        if (! kctl) {
                snd_printk(KERN_ERR "cannot malloc kcontrol\n");
+               kfree(namelist);
                kfree(cval);
                return -ENOMEM;
        }