[PATCH] kdump: i386 save ss esp bug fix

\r)

From: Vivek Goyal <vgoyal@in.ibm.com>

This patch fixes a minor bug based on Andi Kleen's suggestion.  asm's can't be
broken in this particular case, hence merging them.

Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

diff --git a/arch/i386/kernel/crash.c b/arch/i386/kernel/crash.c
index 0248e08..10fe656 100644 (file)
--- a/arch/i386/kernel/crash.c
+++ b/arch/i386/kernel/crash.c
@@ -108,8 +108,10 @@ static void crash_setup_regs(struct pt_regs *newregs, struct pt_regs *oldregs)
 {
        memcpy(newregs, oldregs, sizeof(*newregs));
        newregs->esp = (unsigned long)&(oldregs->esp);
-       __asm__ __volatile__("xorl %eax, %eax;");
-       __asm__ __volatile__ ("movw %%ss, %%ax;" :"=a"(newregs->xss));
+       __asm__ __volatile__(
+                       "xorl %%eax, %%eax\n\t"
+                       "movw %%ss, %%ax\n\t"
+                       :"=a"(newregs->xss));
 }
 
 /* We may have saved_regs from where the error came from