fs/ncpfs/getopt.c: replace simple_strtoul by kstrtoul
authorFabian Frederick <fabf@skynet.be>
Wed, 4 Jun 2014 23:12:21 +0000 (16:12 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 4 Jun 2014 23:54:21 +0000 (16:54 -0700)
Remove obsolete simple_strtoul in ncp_getopt

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Cc: Petr Vandrovec <petr@vandrovec.name>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ncpfs/getopt.c

index 03ffde1..344889c 100644 (file)
@@ -53,15 +53,14 @@ int ncp_getopt(const char *caller, char **options, const struct ncp_option *opts
                                return -EINVAL;
                        }
                        if (opts->has_arg & OPT_INT) {
-                               char* v;
+                               int rc = kstrtoul(val, 0, value);
 
-                               *value = simple_strtoul(val, &v, 0);
-                               if (!*v) {
-                                       return opts->val;
+                               if (rc) {
+                                       pr_info("%s: invalid numeric value in %s=%s\n",
+                                               caller, token, val);
+                                       return rc;
                                }
-                               pr_info("%s: invalid numeric value in %s=%s\n",
-                                       caller, token, val);
-                               return -EDOM;
+                               return opts->val;
                        }
                        if (opts->has_arg & OPT_STRING) {
                                return opts->val;