tcm_fc: move the dereference below the NULL test
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 7 Sep 2012 06:55:32 +0000 (14:55 +0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Tue, 18 Sep 2012 01:04:09 +0000 (18:04 -0700)
The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/tcm_fc/tfc_io.c

index d051102..b6fd4cf 100644 (file)
@@ -327,11 +327,12 @@ drop:
  */
 void ft_invl_hw_context(struct ft_cmd *cmd)
 {
-       struct fc_seq *seq = cmd->seq;
+       struct fc_seq *seq;
        struct fc_exch *ep = NULL;
        struct fc_lport *lport = NULL;
 
        BUG_ON(!cmd);
+       seq = cmd->seq;
 
        /* Cleanup the DDP context in HW if DDP was setup */
        if (cmd->was_ddp_setup && seq) {