[PATCH] x86_64: Only switch to IPI broadcast timer on Intel when C3 is supported
authorVenkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Fri, 3 Feb 2006 20:50:47 +0000 (21:50 +0100)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sun, 5 Feb 2006 00:43:13 +0000 (16:43 -0800)
Bug in apic timer removal on C3 patch. We should switch to IPI from APIC timer
only when C3 state is valid.

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/acpi/processor_idle.c

index be2dae5..3bfca09 100644 (file)
@@ -899,7 +899,7 @@ static int acpi_processor_power_verify(struct acpi_processor *pr)
                case ACPI_STATE_C3:
                        acpi_processor_power_verify_c3(pr, cx);
 #ifdef ARCH_APICTIMER_STOPS_ON_C3
-                       if (c->x86_vendor == X86_VENDOR_INTEL) {
+                       if (cx->valid && c->x86_vendor == X86_VENDOR_INTEL) {
                                on_each_cpu(switch_APIC_timer_to_ipi,
                                                &mask, 1, 1);
                        }