]> git.openpandora.org Git - pandora-kernel.git/commitdiff
netfilter: xt_LOG: don't use xchg() for simple assignment
authorJan Beulich <JBeulich@suse.com>
Wed, 7 Mar 2012 23:45:44 +0000 (23:45 +0000)
committerGrazvydas Ignotas <notasas@gmail.com>
Sun, 28 Feb 2016 01:55:13 +0000 (03:55 +0200)
At least on ia64 the (bogus) use of xchg() here results in the compiler
warning about an unused expression result. As only an assignment is
intended here, convert it to such.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
include/net/netfilter/xt_log.h

index 0dfb34a5b53c3440469e51873d886a5312ec9615..a417c115805d833d5a65a51ea832dea82b18af38 100644 (file)
@@ -47,7 +47,7 @@ static void sb_close(struct sbuff *m)
        if (likely(m != &emergency))
                kfree(m);
        else {
-               xchg(&emergency_ptr, m);
+               emergency_ptr = m;
                local_bh_enable();
        }
 }