s390/module: fix compile warning
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Wed, 27 Feb 2013 15:28:20 +0000 (16:28 +0100)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Thu, 28 Feb 2013 08:37:13 +0000 (09:37 +0100)
Get rid of this one (false positive):
arch/s390/kernel/module.c: In function ‘apply_relocate_add’:
arch/s390/kernel/module.c:404:5: warning: ‘rc’ may be used uninitialized
                                 in this function [-Wmaybe-uninitialized]
arch/s390/kernel/module.c:225:6: note: ‘rc’ was declared here

Play safe and preinitialize rc with an error value, so we see an error
if new users indeed don't initialize it.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
arch/s390/kernel/module.c

index f750bd7..7845e15 100644 (file)
@@ -222,7 +222,7 @@ static int apply_rela(Elf_Rela *rela, Elf_Addr base, Elf_Sym *symtab,
        struct mod_arch_syminfo *info;
        Elf_Addr loc, val;
        int r_type, r_sym;
-       int rc;
+       int rc = -ENOEXEC;
 
        /* This is where to make the change */
        loc = base + rela->r_offset;