clk: fix clk_get_bulk when phandle error
authorNeil Armstrong <narmstrong@baylibre.com>
Tue, 17 Apr 2018 09:30:31 +0000 (11:30 +0200)
committerTom Rini <trini@konsulko.com>
Tue, 17 Apr 2018 21:45:08 +0000 (17:45 -0400)
This fixes the Coverity Defect CID 175347 when dev_count_phandle_with_args()
returns a negative value.

Fixes: a855be87da49 ("clk: Add get/enable/disable/release for a bulk of clocks")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
drivers/clk/clk-uclass.c

index 6e99b3b..53f418b 100644 (file)
@@ -111,8 +111,8 @@ int clk_get_bulk(struct udevice *dev, struct clk_bulk *bulk)
        bulk->count = 0;
 
        count = dev_count_phandle_with_args(dev, "clocks", "#clock-cells");
-       if (!count)
-               return 0;
+       if (count < 1)
+               return count;
 
        bulk->clks = devm_kcalloc(dev, count, sizeof(struct clk), GFP_KERNEL);
        if (!bulk->clks)