staging: rtl8188eu: check for kzalloc failure
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Tue, 21 Jul 2015 13:27:26 +0000 (18:57 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Jul 2015 03:59:54 +0000 (20:59 -0700)
Check for kzalloc failure and directly return from the error patch thus
simplifying the success path.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/os_dep/usb_intf.c

index 09a918e..1c9558f 100644 (file)
@@ -114,13 +114,12 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
        mutex_init(&pdvobjpriv->usb_vendor_req_mutex);
        pdvobjpriv->usb_vendor_req_buf = kzalloc(MAX_USB_IO_CTL_SIZE, GFP_KERNEL);
 
-       if (pdvobjpriv->usb_vendor_req_buf) {
-               usb_get_dev(pusbd);
-       } else {
+       if (!pdvobjpriv->usb_vendor_req_buf) {
                usb_set_intfdata(usb_intf, NULL);
                kfree(pdvobjpriv);
-               pdvobjpriv = NULL;
+               return NULL;
        }
+       usb_get_dev(pusbd);
 
        return pdvobjpriv;
 }