[media] usbvision: coding style
authorHans Verkuil <hverkuil@xs4all.nl>
Wed, 29 Dec 2010 16:53:21 +0000 (13:53 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 30 Dec 2010 10:02:09 +0000 (08:02 -0200)
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/usbvision/usbvision-cards.c
drivers/media/video/usbvision/usbvision-core.c
drivers/media/video/usbvision/usbvision-i2c.c
drivers/media/video/usbvision/usbvision-video.c
drivers/media/video/usbvision/usbvision.h

index acfdb2b..68b998b 100644 (file)
@@ -1026,78 +1026,78 @@ struct usbvision_device_data_st  usbvision_device_data[] = {
                .model_string   = "Hauppauge WinTv-USB",
        },
 };
-const int usbvision_device_data_size=ARRAY_SIZE(usbvision_device_data);
+const int usbvision_device_data_size = ARRAY_SIZE(usbvision_device_data);
 
 /* Supported Devices */
 
-struct usb_device_id usbvision_table [] = {
-       { USB_DEVICE(0x0a6f, 0x0400), .driver_info=XANBOO },
-       { USB_DEVICE(0x050d, 0x0106), .driver_info=BELKIN_VIDEOBUS_II },
-       { USB_DEVICE(0x050d, 0x0207), .driver_info=BELKIN_VIDEOBUS },
-       { USB_DEVICE(0x050d, 0x0208), .driver_info=BELKIN_USB_VIDEOBUS_II },
-       { USB_DEVICE(0x0571, 0x0002), .driver_info=ECHOFX_INTERVIEW_LITE },
-       { USB_DEVICE(0x0573, 0x0003), .driver_info=USBGEAR_USBG_V1 },
-       { USB_DEVICE(0x0573, 0x0400), .driver_info=D_LINK_V100 },
-       { USB_DEVICE(0x0573, 0x2000), .driver_info=X10_USB_CAMERA },
-       { USB_DEVICE(0x0573, 0x2d00), .driver_info=HPG_WINTV_LIVE_PAL_BG },
-       { USB_DEVICE(0x0573, 0x2d01), .driver_info=HPG_WINTV_LIVE_PRO_NTSC_MN },
-       { USB_DEVICE(0x0573, 0x2101), .driver_info=ZORAN_PMD_NOGATECH },
-       { USB_DEVICE(0x0573, 0x4100), .driver_info=NOGATECH_USB_TV_NTSC_FM },
-       { USB_DEVICE(0x0573, 0x4110), .driver_info=PNY_USB_TV_NTSC_FM },
-       { USB_DEVICE(0x0573, 0x4450), .driver_info=PV_PLAYTV_USB_PRO_PAL_FM },
-       { USB_DEVICE(0x0573, 0x4550), .driver_info=ZT_721 },
-       { USB_DEVICE(0x0573, 0x4d00), .driver_info=HPG_WINTV_NTSC_MN },
-       { USB_DEVICE(0x0573, 0x4d01), .driver_info=HPG_WINTV_PAL_BG },
-       { USB_DEVICE(0x0573, 0x4d02), .driver_info=HPG_WINTV_PAL_I },
-       { USB_DEVICE(0x0573, 0x4d03), .driver_info=HPG_WINTV_PAL_SECAM_L },
-       { USB_DEVICE(0x0573, 0x4d04), .driver_info=HPG_WINTV_PAL_D_K },
-       { USB_DEVICE(0x0573, 0x4d10), .driver_info=HPG_WINTV_NTSC_FM },
-       { USB_DEVICE(0x0573, 0x4d11), .driver_info=HPG_WINTV_PAL_BG_FM },
-       { USB_DEVICE(0x0573, 0x4d12), .driver_info=HPG_WINTV_PAL_I_FM },
-       { USB_DEVICE(0x0573, 0x4d14), .driver_info=HPG_WINTV_PAL_D_K_FM },
-       { USB_DEVICE(0x0573, 0x4d2a), .driver_info=HPG_WINTV_PRO_NTSC_MN },
-       { USB_DEVICE(0x0573, 0x4d2b), .driver_info=HPG_WINTV_PRO_NTSC_MN_V2 },
-       { USB_DEVICE(0x0573, 0x4d2c), .driver_info=HPG_WINTV_PRO_PAL },
+struct usb_device_id usbvision_table[] = {
+       { USB_DEVICE(0x0a6f, 0x0400), .driver_info = XANBOO },
+       { USB_DEVICE(0x050d, 0x0106), .driver_info = BELKIN_VIDEOBUS_II },
+       { USB_DEVICE(0x050d, 0x0207), .driver_info = BELKIN_VIDEOBUS },
+       { USB_DEVICE(0x050d, 0x0208), .driver_info = BELKIN_USB_VIDEOBUS_II },
+       { USB_DEVICE(0x0571, 0x0002), .driver_info = ECHOFX_INTERVIEW_LITE },
+       { USB_DEVICE(0x0573, 0x0003), .driver_info = USBGEAR_USBG_V1 },
+       { USB_DEVICE(0x0573, 0x0400), .driver_info = D_LINK_V100 },
+       { USB_DEVICE(0x0573, 0x2000), .driver_info = X10_USB_CAMERA },
+       { USB_DEVICE(0x0573, 0x2d00), .driver_info = HPG_WINTV_LIVE_PAL_BG },
+       { USB_DEVICE(0x0573, 0x2d01), .driver_info = HPG_WINTV_LIVE_PRO_NTSC_MN },
+       { USB_DEVICE(0x0573, 0x2101), .driver_info = ZORAN_PMD_NOGATECH },
+       { USB_DEVICE(0x0573, 0x4100), .driver_info = NOGATECH_USB_TV_NTSC_FM },
+       { USB_DEVICE(0x0573, 0x4110), .driver_info = PNY_USB_TV_NTSC_FM },
+       { USB_DEVICE(0x0573, 0x4450), .driver_info = PV_PLAYTV_USB_PRO_PAL_FM },
+       { USB_DEVICE(0x0573, 0x4550), .driver_info = ZT_721 },
+       { USB_DEVICE(0x0573, 0x4d00), .driver_info = HPG_WINTV_NTSC_MN },
+       { USB_DEVICE(0x0573, 0x4d01), .driver_info = HPG_WINTV_PAL_BG },
+       { USB_DEVICE(0x0573, 0x4d02), .driver_info = HPG_WINTV_PAL_I },
+       { USB_DEVICE(0x0573, 0x4d03), .driver_info = HPG_WINTV_PAL_SECAM_L },
+       { USB_DEVICE(0x0573, 0x4d04), .driver_info = HPG_WINTV_PAL_D_K },
+       { USB_DEVICE(0x0573, 0x4d10), .driver_info = HPG_WINTV_NTSC_FM },
+       { USB_DEVICE(0x0573, 0x4d11), .driver_info = HPG_WINTV_PAL_BG_FM },
+       { USB_DEVICE(0x0573, 0x4d12), .driver_info = HPG_WINTV_PAL_I_FM },
+       { USB_DEVICE(0x0573, 0x4d14), .driver_info = HPG_WINTV_PAL_D_K_FM },
+       { USB_DEVICE(0x0573, 0x4d2a), .driver_info = HPG_WINTV_PRO_NTSC_MN },
+       { USB_DEVICE(0x0573, 0x4d2b), .driver_info = HPG_WINTV_PRO_NTSC_MN_V2 },
+       { USB_DEVICE(0x0573, 0x4d2c), .driver_info = HPG_WINTV_PRO_PAL },
        { USB_DEVICE(0x0573, 0x4d20), .driver_info = HPG_WINTV_PRO_NTSC_MN_V3 },
-       { USB_DEVICE(0x0573, 0x4d21), .driver_info=HPG_WINTV_PRO_PAL_BG },
-       { USB_DEVICE(0x0573, 0x4d22), .driver_info=HPG_WINTV_PRO_PAL_I },
-       { USB_DEVICE(0x0573, 0x4d23), .driver_info=HPG_WINTV_PRO_PAL_SECAM_L },
-       { USB_DEVICE(0x0573, 0x4d24), .driver_info=HPG_WINTV_PRO_PAL_D_K },
-       { USB_DEVICE(0x0573, 0x4d25), .driver_info=HPG_WINTV_PRO_PAL_SECAM },
-       { USB_DEVICE(0x0573, 0x4d26), .driver_info=HPG_WINTV_PRO_PAL_SECAM_V2 },
-       { USB_DEVICE(0x0573, 0x4d27), .driver_info=HPG_WINTV_PRO_PAL_BG_V2 },
-       { USB_DEVICE(0x0573, 0x4d28), .driver_info=HPG_WINTV_PRO_PAL_BG_D_K },
-       { USB_DEVICE(0x0573, 0x4d29), .driver_info=HPG_WINTV_PRO_PAL_I_D_K },
-       { USB_DEVICE(0x0573, 0x4d30), .driver_info=HPG_WINTV_PRO_NTSC_MN_FM },
-       { USB_DEVICE(0x0573, 0x4d31), .driver_info=HPG_WINTV_PRO_PAL_BG_FM },
-       { USB_DEVICE(0x0573, 0x4d32), .driver_info=HPG_WINTV_PRO_PAL_I_FM },
-       { USB_DEVICE(0x0573, 0x4d34), .driver_info=HPG_WINTV_PRO_PAL_D_K_FM },
-       { USB_DEVICE(0x0573, 0x4d35), .driver_info=HPG_WINTV_PRO_TEMIC_PAL_FM },
-       { USB_DEVICE(0x0573, 0x4d36), .driver_info=HPG_WINTV_PRO_TEMIC_PAL_BG_FM },
-       { USB_DEVICE(0x0573, 0x4d37), .driver_info=HPG_WINTV_PRO_PAL_FM },
-       { USB_DEVICE(0x0573, 0x4d38), .driver_info=HPG_WINTV_PRO_NTSC_MN_FM_V2 },
-       { USB_DEVICE(0x0768, 0x0006), .driver_info=CAMTEL_TVB330 },
-       { USB_DEVICE(0x07d0, 0x0001), .driver_info=DIGITAL_VIDEO_CREATOR_I },
-       { USB_DEVICE(0x07d0, 0x0002), .driver_info=GLOBAL_VILLAGE_GV_007_NTSC },
-       { USB_DEVICE(0x07d0, 0x0003), .driver_info=DAZZLE_DVC_50_REV_1_NTSC },
-       { USB_DEVICE(0x07d0, 0x0004), .driver_info=DAZZLE_DVC_80_REV_1_PAL },
-       { USB_DEVICE(0x07d0, 0x0005), .driver_info=DAZZLE_DVC_90_REV_1_SECAM },
-       { USB_DEVICE(0x07f8, 0x9104), .driver_info=ESKAPE_LABS_MYTV2GO },
-       { USB_DEVICE(0x2304, 0x010d), .driver_info=PINNA_PCTV_USB_PAL },
-       { USB_DEVICE(0x2304, 0x0109), .driver_info=PINNA_PCTV_USB_SECAM },
-       { USB_DEVICE(0x2304, 0x0110), .driver_info=PINNA_PCTV_USB_PAL_FM },
-       { USB_DEVICE(0x2304, 0x0111), .driver_info=MIRO_PCTV_USB },
-       { USB_DEVICE(0x2304, 0x0112), .driver_info=PINNA_PCTV_USB_NTSC_FM },
+       { USB_DEVICE(0x0573, 0x4d21), .driver_info = HPG_WINTV_PRO_PAL_BG },
+       { USB_DEVICE(0x0573, 0x4d22), .driver_info = HPG_WINTV_PRO_PAL_I },
+       { USB_DEVICE(0x0573, 0x4d23), .driver_info = HPG_WINTV_PRO_PAL_SECAM_L },
+       { USB_DEVICE(0x0573, 0x4d24), .driver_info = HPG_WINTV_PRO_PAL_D_K },
+       { USB_DEVICE(0x0573, 0x4d25), .driver_info = HPG_WINTV_PRO_PAL_SECAM },
+       { USB_DEVICE(0x0573, 0x4d26), .driver_info = HPG_WINTV_PRO_PAL_SECAM_V2 },
+       { USB_DEVICE(0x0573, 0x4d27), .driver_info = HPG_WINTV_PRO_PAL_BG_V2 },
+       { USB_DEVICE(0x0573, 0x4d28), .driver_info = HPG_WINTV_PRO_PAL_BG_D_K },
+       { USB_DEVICE(0x0573, 0x4d29), .driver_info = HPG_WINTV_PRO_PAL_I_D_K },
+       { USB_DEVICE(0x0573, 0x4d30), .driver_info = HPG_WINTV_PRO_NTSC_MN_FM },
+       { USB_DEVICE(0x0573, 0x4d31), .driver_info = HPG_WINTV_PRO_PAL_BG_FM },
+       { USB_DEVICE(0x0573, 0x4d32), .driver_info = HPG_WINTV_PRO_PAL_I_FM },
+       { USB_DEVICE(0x0573, 0x4d34), .driver_info = HPG_WINTV_PRO_PAL_D_K_FM },
+       { USB_DEVICE(0x0573, 0x4d35), .driver_info = HPG_WINTV_PRO_TEMIC_PAL_FM },
+       { USB_DEVICE(0x0573, 0x4d36), .driver_info = HPG_WINTV_PRO_TEMIC_PAL_BG_FM },
+       { USB_DEVICE(0x0573, 0x4d37), .driver_info = HPG_WINTV_PRO_PAL_FM },
+       { USB_DEVICE(0x0573, 0x4d38), .driver_info = HPG_WINTV_PRO_NTSC_MN_FM_V2 },
+       { USB_DEVICE(0x0768, 0x0006), .driver_info = CAMTEL_TVB330 },
+       { USB_DEVICE(0x07d0, 0x0001), .driver_info = DIGITAL_VIDEO_CREATOR_I },
+       { USB_DEVICE(0x07d0, 0x0002), .driver_info = GLOBAL_VILLAGE_GV_007_NTSC },
+       { USB_DEVICE(0x07d0, 0x0003), .driver_info = DAZZLE_DVC_50_REV_1_NTSC },
+       { USB_DEVICE(0x07d0, 0x0004), .driver_info = DAZZLE_DVC_80_REV_1_PAL },
+       { USB_DEVICE(0x07d0, 0x0005), .driver_info = DAZZLE_DVC_90_REV_1_SECAM },
+       { USB_DEVICE(0x07f8, 0x9104), .driver_info = ESKAPE_LABS_MYTV2GO },
+       { USB_DEVICE(0x2304, 0x010d), .driver_info = PINNA_PCTV_USB_PAL },
+       { USB_DEVICE(0x2304, 0x0109), .driver_info = PINNA_PCTV_USB_SECAM },
+       { USB_DEVICE(0x2304, 0x0110), .driver_info = PINNA_PCTV_USB_PAL_FM },
+       { USB_DEVICE(0x2304, 0x0111), .driver_info = MIRO_PCTV_USB },
+       { USB_DEVICE(0x2304, 0x0112), .driver_info = PINNA_PCTV_USB_NTSC_FM },
        { USB_DEVICE(0x2304, 0x0113),
          .driver_info = PINNA_PCTV_USB_NTSC_FM_V3 },
-       { USB_DEVICE(0x2304, 0x0210), .driver_info=PINNA_PCTV_USB_PAL_FM_V2 },
-       { USB_DEVICE(0x2304, 0x0212), .driver_info=PINNA_PCTV_USB_NTSC_FM_V2 },
-       { USB_DEVICE(0x2304, 0x0214), .driver_info=PINNA_PCTV_USB_PAL_FM_V3 },
-       { USB_DEVICE(0x2304, 0x0300), .driver_info=PINNA_LINX_VD_IN_CAB_NTSC },
-       { USB_DEVICE(0x2304, 0x0301), .driver_info=PINNA_LINX_VD_IN_CAB_PAL },
-       { USB_DEVICE(0x2304, 0x0419), .driver_info=PINNA_PCTV_BUNGEE_PAL_FM },
-       { USB_DEVICE(0x2400, 0x4200), .driver_info=HPG_WINTV },
+       { USB_DEVICE(0x2304, 0x0210), .driver_info = PINNA_PCTV_USB_PAL_FM_V2 },
+       { USB_DEVICE(0x2304, 0x0212), .driver_info = PINNA_PCTV_USB_NTSC_FM_V2 },
+       { USB_DEVICE(0x2304, 0x0214), .driver_info = PINNA_PCTV_USB_PAL_FM_V3 },
+       { USB_DEVICE(0x2304, 0x0300), .driver_info = PINNA_LINX_VD_IN_CAB_NTSC },
+       { USB_DEVICE(0x2304, 0x0301), .driver_info = PINNA_LINX_VD_IN_CAB_PAL },
+       { USB_DEVICE(0x2304, 0x0419), .driver_info = PINNA_PCTV_BUNGEE_PAL_FM },
+       { USB_DEVICE(0x2400, 0x4200), .driver_info = HPG_WINTV },
        { },    /* terminate list */
 };
 
-MODULE_DEVICE_TABLE (usb, usbvision_table);
+MODULE_DEVICE_TABLE(usb, usbvision_table);
index 64a9133..c8feb0d 100644 (file)
@@ -33,7 +33,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/spinlock.h>
-#include <asm/io.h>
+#include <linux/io.h>
 #include <linux/videodev2.h>
 #include <linux/i2c.h>
 
 #include "usbvision.h"
 
 static unsigned int core_debug;
-module_param(core_debug,int,0644);
-MODULE_PARM_DESC(core_debug,"enable debug messages [core]");
+module_param(core_debug, int, 0644);
+MODULE_PARM_DESC(core_debug, "enable debug messages [core]");
 
 static unsigned int force_testpattern;
-module_param(force_testpattern,int,0644);
-MODULE_PARM_DESC(force_testpattern,"enable test pattern display [core]");
+module_param(force_testpattern, int, 0644);
+MODULE_PARM_DESC(force_testpattern, "enable test pattern display [core]");
 
 static int adjust_compression = 1;     /* Set the compression to be adaptive */
 module_param(adjust_compression, int, 0444);
@@ -82,15 +82,15 @@ MODULE_PARM_DESC(adjust_y_offset, "adjust Y offset display [core]");
                                __func__, __LINE__ , ## args); \
        }
 #else
-       #define PDEBUG(level, fmt, args...) do {} while(0)
+       #define PDEBUG(level, fmt, args...) do {} while (0)
 #endif
 
-#define DBG_HEADER     1<<0
-#define DBG_IRQ                1<<1
-#define DBG_ISOC       1<<2
-#define DBG_PARSE      1<<3
-#define DBG_SCRATCH    1<<4
-#define DBG_FUNC       1<<5
+#define DBG_HEADER     (1 << 0)
+#define DBG_IRQ                (1 << 1)
+#define DBG_ISOC       (1 << 2)
+#define DBG_PARSE      (1 << 3)
+#define DBG_SCRATCH    (1 << 4)
+#define DBG_FUNC       (1 << 5)
 
 static const int max_imgwidth = MAX_FRAME_WIDTH;
 static const int max_imgheight = MAX_FRAME_HEIGHT;
@@ -107,10 +107,10 @@ static const int min_imgheight = MIN_FRAME_HEIGHT;
 static const int scratch_buf_size = DEFAULT_SCRATCH_BUF_SIZE;
 
 /* Function prototypes */
-static int usbvision_request_intra (struct usb_usbvision *usbvision);
-static int usbvision_unrequest_intra (struct usb_usbvision *usbvision);
-static int usbvision_adjust_compression (struct usb_usbvision *usbvision);
-static int usbvision_measure_bandwidth (struct usb_usbvision *usbvision);
+static int usbvision_request_intra(struct usb_usbvision *usbvision);
+static int usbvision_unrequest_intra(struct usb_usbvision *usbvision);
+static int usbvision_adjust_compression(struct usb_usbvision *usbvision);
+static int usbvision_measure_bandwidth(struct usb_usbvision *usbvision);
 
 /*******************************/
 /* Memory management functions */
@@ -176,7 +176,7 @@ static void usbvision_hexdump(const unsigned char *data, int len)
                k += sprintf(&tmp[k], "%02x ", data[i]);
        }
        if (k > 0)
-               printk("%s\n", tmp);
+               printk(KERN_CONT "%s\n", tmp);
 }
 #endif
 
@@ -186,9 +186,9 @@ static void usbvision_hexdump(const unsigned char *data, int len)
 static int scratch_len(struct usb_usbvision *usbvision)    /* This returns the amount of data actually in the buffer */
 {
        int len = usbvision->scratch_write_ptr - usbvision->scratch_read_ptr;
-       if (len < 0) {
+
+       if (len < 0)
                len += scratch_buf_size;
-       }
        PDEBUG(DBG_SCRATCH, "scratch_len() = %d\n", len);
 
        return len;
@@ -199,9 +199,8 @@ static int scratch_len(struct usb_usbvision *usbvision)    /* This returns the a
 static int scratch_free(struct usb_usbvision *usbvision)
 {
        int free = usbvision->scratch_read_ptr - usbvision->scratch_write_ptr;
-       if (free <= 0) {
+       if (free <= 0)
                free += scratch_buf_size;
-       }
        if (free) {
                free -= 1;                                                      /* at least one byte in the buffer must */
                                                                                /* left blank, otherwise there is no chance to differ between full and empty */
@@ -221,14 +220,12 @@ static int scratch_put(struct usb_usbvision *usbvision, unsigned char *data,
        if (usbvision->scratch_write_ptr + len < scratch_buf_size) {
                memcpy(usbvision->scratch + usbvision->scratch_write_ptr, data, len);
                usbvision->scratch_write_ptr += len;
-       }
-       else {
+       } else {
                len_part = scratch_buf_size - usbvision->scratch_write_ptr;
                memcpy(usbvision->scratch + usbvision->scratch_write_ptr, data, len_part);
                if (len == len_part) {
                        usbvision->scratch_write_ptr = 0;                       /* just set write_ptr to zero */
-               }
-               else {
+               } else {
                        memcpy(usbvision->scratch, data + len_part, len - len_part);
                        usbvision->scratch_write_ptr = len - len_part;
                }
@@ -255,17 +252,16 @@ static int scratch_get_extra(struct usb_usbvision *usbvision,
                             unsigned char *data, int *ptr, int len)
 {
        int len_part;
+
        if (*ptr + len < scratch_buf_size) {
                memcpy(data, usbvision->scratch + *ptr, len);
                *ptr += len;
-       }
-       else {
+       } else {
                len_part = scratch_buf_size - *ptr;
                memcpy(data, usbvision->scratch + *ptr, len_part);
                if (len == len_part) {
                        *ptr = 0;                                                       /* just set the y_ptr to zero */
-               }
-               else {
+               } else {
                        memcpy(data + len_part, usbvision->scratch, len - len_part);
                        *ptr = len - len_part;
                }
@@ -281,7 +277,7 @@ static int scratch_get_extra(struct usb_usbvision *usbvision,
 static void scratch_set_extra_ptr(struct usb_usbvision *usbvision, int *ptr,
                                  int len)
 {
-       *ptr = (usbvision->scratch_read_ptr + len)%scratch_buf_size;
+       *ptr = (usbvision->scratch_read_ptr + len) % scratch_buf_size;
 
        PDEBUG(DBG_SCRATCH, "ptr=%d\n", *ptr);
 }
@@ -301,17 +297,16 @@ static int scratch_get(struct usb_usbvision *usbvision, unsigned char *data,
                       int len)
 {
        int len_part;
+
        if (usbvision->scratch_read_ptr + len < scratch_buf_size) {
                memcpy(data, usbvision->scratch + usbvision->scratch_read_ptr, len);
                usbvision->scratch_read_ptr += len;
-       }
-       else {
+       } else {
                len_part = scratch_buf_size - usbvision->scratch_read_ptr;
                memcpy(data, usbvision->scratch + usbvision->scratch_read_ptr, len_part);
                if (len == len_part) {
                        usbvision->scratch_read_ptr = 0;                                /* just set the read_ptr to zero */
-               }
-               else {
+               } else {
                        memcpy(data + len_part, usbvision->scratch, len - len_part);
                        usbvision->scratch_read_ptr = len - len_part;
                }
@@ -355,7 +350,6 @@ static int scratch_get_header(struct usb_usbvision *usbvision,
 /* This removes len bytes of old data from the buffer */
 static void scratch_rm_old(struct usb_usbvision *usbvision, int len)
 {
-
        usbvision->scratch_read_ptr += len;
        usbvision->scratch_read_ptr %= scratch_buf_size;
        PDEBUG(DBG_SCRATCH, "read_ptr is now %d\n", usbvision->scratch_read_ptr);
@@ -378,7 +372,7 @@ int usbvision_scratch_alloc(struct usb_usbvision *usbvision)
 {
        usbvision->scratch = vmalloc_32(scratch_buf_size);
        scratch_reset(usbvision);
-       if(usbvision->scratch == NULL) {
+       if (usbvision->scratch == NULL) {
                dev_err(&usbvision->dev->dev,
                        "%s: unable to allocate %d bytes for scratch\n",
                                __func__, scratch_buf_size);
@@ -391,7 +385,6 @@ void usbvision_scratch_free(struct usb_usbvision *usbvision)
 {
        vfree(usbvision->scratch);
        usbvision->scratch = NULL;
-
 }
 
 /*
@@ -476,7 +469,6 @@ static void usbvision_testpattern(struct usb_usbvision *usbvision,
        frame->grabstate = frame_state_done;
        frame->scanlength += scan_length;
        ++num_pass;
-
 }
 
 /*
@@ -487,6 +479,7 @@ static void usbvision_testpattern(struct usb_usbvision *usbvision,
 int usbvision_decompress_alloc(struct usb_usbvision *usbvision)
 {
        int IFB_size = MAX_FRAME_WIDTH * MAX_FRAME_HEIGHT * 3 / 2;
+
        usbvision->intra_frame_buffer = vmalloc_32(IFB_size);
        if (usbvision->intra_frame_buffer == NULL) {
                dev_err(&usbvision->dev->dev,
@@ -545,8 +538,7 @@ static enum parse_state usbvision_find_header(struct usb_usbvision *usbvision)
                                usbvision_unrequest_intra(usbvision);
                                break;
                        }
-               }
-               else {
+               } else {
                        found_header = 1;
                        break;
                }
@@ -555,16 +547,15 @@ static enum parse_state usbvision_find_header(struct usb_usbvision *usbvision)
        if (found_header) {
                frame->frmwidth = frame->isoc_header.frame_width * usbvision->stretch_width;
                frame->frmheight = frame->isoc_header.frame_height * usbvision->stretch_height;
-               frame->v4l2_linesize = (frame->frmwidth * frame->v4l2_format.depth)>> 3;
-       }
-       else { /* no header found */
+               frame->v4l2_linesize = (frame->frmwidth * frame->v4l2_format.depth) >> 3;
+       } else { /* no header found */
                PDEBUG(DBG_HEADER, "skipping scratch data, no header");
                scratch_reset(usbvision);
                return parse_state_end_parse;
        }
 
        /* found header */
-       if (frame->isoc_header.data_format==ISOC_MODE_COMPRESS) {
+       if (frame->isoc_header.data_format == ISOC_MODE_COMPRESS) {
                /* check isoc_header.frame_num for lost frames */
                if (usbvision->last_isoc_frame_num >= 0) {
                        if (((usbvision->last_isoc_frame_num + 1) % 32) != frame->isoc_header.frame_num) {
@@ -594,7 +585,7 @@ static enum parse_state usbvision_parse_lines_422(struct usb_usbvision *usbvisio
        unsigned char *f;
        int len;
        int i;
-       unsigned char yuyv[4]={180, 128, 10, 128}; /* YUV components */
+       unsigned char yuyv[4] = { 180, 128, 10, 128 }; /* YUV components */
        unsigned char rv, gv, bv;       /* RGB components */
        int clipmask_index, bytes_per_pixel;
        int stretch_bytes, clipmask_add;
@@ -603,31 +594,27 @@ static enum parse_state usbvision_parse_lines_422(struct usb_usbvision *usbvisio
        f = frame->data + (frame->v4l2_linesize * frame->curline);
 
        /* Make sure there's enough data for the entire line */
-       len = (frame->isoc_header.frame_width * 2)+5;
+       len = (frame->isoc_header.frame_width * 2) + 5;
        if (scratch_len(usbvision) < len) {
                PDEBUG(DBG_PARSE, "out of data in line %d, need %u.\n", frame->curline, len);
                return parse_state_out;
        }
 
-       if ((frame->curline + 1) >= frame->frmheight) {
+       if ((frame->curline + 1) >= frame->frmheight)
                return parse_state_next_frame;
-       }
 
        bytes_per_pixel = frame->v4l2_format.bytes_per_pixel;
        stretch_bytes = (usbvision->stretch_width - 1) * bytes_per_pixel;
        clipmask_index = frame->curline * MAX_FRAME_WIDTH;
        clipmask_add = usbvision->stretch_width;
 
-       for (i = 0; i < frame->frmwidth; i+=(2 * usbvision->stretch_width)) {
-
+       for (i = 0; i < frame->frmwidth; i += (2 * usbvision->stretch_width)) {
                scratch_get(usbvision, &yuyv[0], 4);
 
                if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                        *f++ = yuyv[0]; /* Y */
                        *f++ = yuyv[3]; /* U */
-               }
-               else {
-
+               } else {
                        YUV_TO_RGB_BY_THE_BOOK(yuyv[0], yuyv[1], yuyv[3], rv, gv, bv);
                        switch (frame->v4l2_format.format) {
                        case V4L2_PIX_FMT_RGB565:
@@ -661,9 +648,7 @@ static enum parse_state usbvision_parse_lines_422(struct usb_usbvision *usbvisio
                if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                        *f++ = yuyv[2]; /* Y */
                        *f++ = yuyv[1]; /* V */
-               }
-               else {
-
+               } else {
                        YUV_TO_RGB_BY_THE_BOOK(yuyv[2], yuyv[1], yuyv[3], rv, gv, bv);
                        switch (frame->v4l2_format.format) {
                        case V4L2_PIX_FMT_RGB565:
@@ -698,16 +683,13 @@ static enum parse_state usbvision_parse_lines_422(struct usb_usbvision *usbvisio
        frame->curline += usbvision->stretch_height;
        *pcopylen += frame->v4l2_linesize * usbvision->stretch_height;
 
-       if (frame->curline >= frame->frmheight) {
+       if (frame->curline >= frame->frmheight)
                return parse_state_next_frame;
-       }
-       else {
-               return parse_state_continue;
-       }
+       return parse_state_continue;
 }
 
 /* The decompression routine  */
-static int usbvision_decompress(struct usb_usbvision *usbvision,unsigned char *compressed,
+static int usbvision_decompress(struct usb_usbvision *usbvision, unsigned char *compressed,
                                                                unsigned char *decompressed, int *start_pos,
                                                                int *block_typestart_pos, int len)
 {
@@ -728,9 +710,8 @@ static int usbvision_decompress(struct usb_usbvision *usbvision,unsigned char *c
        rest_pixel = len;
 
        for (idx = 0; idx < len; idx++) {
-
                if (block_len == 0) {
-                       if (block_type_len==0) {
+                       if (block_type_len == 0) {
                                block_type_byte = compressed[block_type_pos];
                                block_type_pos++;
                                block_type_len = 4;
@@ -742,7 +723,7 @@ static int usbvision_decompress(struct usb_usbvision *usbvision,unsigned char *c
 
                        pos = extra_pos;
                        if (block_type == 0) {
-                               if(rest_pixel >= 24) {
+                               if (rest_pixel >= 24) {
                                        idx += 23;
                                        rest_pixel -= 24;
                                        integrator = decompressed[idx];
@@ -753,11 +734,10 @@ static int usbvision_decompress(struct usb_usbvision *usbvision,unsigned char *c
                        } else {
                                block_code = compressed[pos];
                                pos++;
-                               if (rest_pixel >= 24) {
+                               if (rest_pixel >= 24)
                                        block_len  = 24;
-                               } else {
+                               else
                                        block_len = rest_pixel;
-                               }
                                rest_pixel -= block_len;
                                extra_pos = pos + (block_len / 4);
                        }
@@ -765,24 +745,23 @@ static int usbvision_decompress(struct usb_usbvision *usbvision,unsigned char *c
                        block_type_len -= 1;
                }
                if (block_len > 0) {
-                       if ((block_len%4) == 0) {
+                       if ((block_len % 4) == 0) {
                                block_byte = compressed[pos];
                                pos++;
                        }
-                       if (block_type == 1) /* inter Block */
+                       if (block_type == 1) /* inter Block */
                                integrator = decompressed[idx];
-                       }
                        switch (block_byte & 0xC0) {
-                               case 0x03<<6:
-                                       integrator += compressed[extra_pos];
-                                       extra_pos++;
-                                       break;
-                               case 0x02<<6:
-                                       integrator += block_code;
-                                       break;
-                               case 0x00:
-                                       integrator -= block_code;
-                                       break;
+                       case 0x03 << 6:
+                               integrator += compressed[extra_pos];
+                               extra_pos++;
+                               break;
+                       case 0x02 << 6:
+                               integrator += block_code;
+                               break;
+                       case 0x00:
+                               integrator -= block_code;
+                               break;
                        }
                        decompressed[idx] = integrator;
                        block_byte <<= 2;
@@ -811,45 +790,40 @@ static enum parse_state usbvision_parse_compress(struct usb_usbvision *usbvision
 #define USBVISION_STRIP_HEADER_LEN     3
 
        struct usbvision_frame *frame;
-       unsigned char *f,*u = NULL ,*v = NULL;
+       unsigned char *f, *u = NULL, *v = NULL;
        unsigned char strip_data[USBVISION_STRIP_LEN_MAX];
        unsigned char strip_header[USBVISION_STRIP_HEADER_LEN];
-       int idx, idx_end, strip_len, strip_ptr, Startblock_pos, block_pos, block_type_pos;
+       int idx, idx_end, strip_len, strip_ptr, startblock_pos, block_pos, block_type_pos;
        int clipmask_index, bytes_per_pixel, rc;
        int image_size;
        unsigned char rv, gv, bv;
        static unsigned char *Y, *U, *V;
 
-       frame  = usbvision->cur_frame;
+       frame = usbvision->cur_frame;
        image_size = frame->frmwidth * frame->frmheight;
-       if ( (frame->v4l2_format.format == V4L2_PIX_FMT_YUV422P) ||
-            (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420) ) {       /* this is a planar format */
+       if ((frame->v4l2_format.format == V4L2_PIX_FMT_YUV422P) ||
+           (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420)) {       /* this is a planar format */
                /* ... v4l2_linesize not used here. */
                f = frame->data + (frame->width * frame->curline);
        } else
                f = frame->data + (frame->v4l2_linesize * frame->curline);
 
-       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV){ /* initialise u and v pointers */
+       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) { /* initialise u and v pointers */
                /* get base of u and b planes add halfoffset */
-
                u = frame->data
                        + image_size
-                       + (frame->frmwidth >>1) * frame->curline ;
-               v = u + (image_size >>1 );
-
-       } else if (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420){
-
-               v = frame->data + image_size + ((frame->curline* (frame->width))>>2) ;
-               u = v + (image_size >>2) ;
+                       + (frame->frmwidth >> 1) * frame->curline;
+               v = u + (image_size >> 1);
+       } else if (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420) {
+               v = frame->data + image_size + ((frame->curline * (frame->width)) >> 2);
+               u = v + (image_size >> 2);
        }
 
-       if (frame->curline == 0) {
+       if (frame->curline == 0)
                usbvision_adjust_compression(usbvision);
-       }
 
-       if (scratch_len(usbvision) < USBVISION_STRIP_HEADER_LEN) {
+       if (scratch_len(usbvision) < USBVISION_STRIP_HEADER_LEN)
                return parse_state_out;
-       }
 
        /* get strip header without changing the scratch_read_ptr */
        scratch_set_extra_ptr(usbvision, &strip_ptr, 0);
@@ -863,7 +837,7 @@ static enum parse_state usbvision_parse_compress(struct usb_usbvision *usbvision
        }
 
        if (frame->curline != (int)strip_header[2]) {
-               /* line number missmatch error */
+               /* line number mismatch error */
                usbvision->strip_line_number_errors++;
        }
 
@@ -883,8 +857,7 @@ static enum parse_state usbvision_parse_compress(struct usb_usbvision *usbvision
                Y = usbvision->intra_frame_buffer + frame->frmwidth * frame->curline;
                U = usbvision->intra_frame_buffer + image_size + (frame->frmwidth / 2) * (frame->curline / 2);
                V = usbvision->intra_frame_buffer + image_size / 4 * 5 + (frame->frmwidth / 2) * (frame->curline / 2);
-       }
-       else {
+       } else {
                return parse_state_next_frame;
        }
 
@@ -895,107 +868,87 @@ static enum parse_state usbvision_parse_compress(struct usb_usbvision *usbvision
 
        idx_end = frame->frmwidth;
        block_type_pos = USBVISION_STRIP_HEADER_LEN;
-       Startblock_pos = block_type_pos + (idx_end - 1) / 96 + (idx_end / 2 - 1) / 96 + 2;
-       block_pos = Startblock_pos;
+       startblock_pos = block_type_pos + (idx_end - 1) / 96 + (idx_end / 2 - 1) / 96 + 2;
+       block_pos = startblock_pos;
 
        usbvision->block_pos = block_pos;
 
-       if ((rc = usbvision_decompress(usbvision, strip_data, Y, &block_pos, &block_type_pos, idx_end)) != idx_end) {
-               /* return parse_state_continue; */
-       }
-       if (strip_len > usbvision->max_strip_len) {
+       rc = usbvision_decompress(usbvision, strip_data, Y, &block_pos, &block_type_pos, idx_end);
+       if (strip_len > usbvision->max_strip_len)
                usbvision->max_strip_len = strip_len;
-       }
 
-       if (frame->curline%2) {
-               if ((rc = usbvision_decompress(usbvision, strip_data, V, &block_pos, &block_type_pos, idx_end/2)) != idx_end/2) {
-               /* return parse_state_continue; */
-               }
-       }
-       else {
-               if ((rc = usbvision_decompress(usbvision, strip_data, U, &block_pos, &block_type_pos, idx_end/2)) != idx_end/2) {
-                       /* return parse_state_continue; */
-               }
-       }
+       if (frame->curline % 2)
+               rc = usbvision_decompress(usbvision, strip_data, V, &block_pos, &block_type_pos, idx_end / 2);
+       else
+               rc = usbvision_decompress(usbvision, strip_data, U, &block_pos, &block_type_pos, idx_end / 2);
 
-       if (block_pos > usbvision->comprblock_pos) {
+       if (block_pos > usbvision->comprblock_pos)
                usbvision->comprblock_pos = block_pos;
-       }
-       if (block_pos > strip_len) {
+       if (block_pos > strip_len)
                usbvision->strip_len_errors++;
-       }
 
        for (idx = 0; idx < idx_end; idx++) {
-               if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+               if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                        *f++ = Y[idx];
-                       *f++ = idx & 0x01 ? U[idx/2] : V[idx/2];
-               }
-               else if(frame->v4l2_format.format == V4L2_PIX_FMT_YUV422P) {
+                       *f++ = idx & 0x01 ? U[idx / 2] : V[idx / 2];
+               } else if (frame->v4l2_format.format == V4L2_PIX_FMT_YUV422P) {
                        *f++ = Y[idx];
-                       if ( idx & 0x01)
-                               *u++ = U[idx>>1] ;
+                       if (idx & 0x01)
+                               *u++ = U[idx >> 1];
                        else
-                               *v++ = V[idx>>1];
-               }
-               else if (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420) {
-                       *f++ = Y [idx];
-                       if ( !((  idx & 0x01  ) | (  frame->curline & 0x01  )) ){
-
-/*                              only need do this for 1 in 4 pixels */
-/*                              intraframe buffer is YUV420 format */
-
-                               *u++ = U[idx >>1];
-                               *v++ = V[idx >>1];
+                               *v++ = V[idx >> 1];
+               } else if (frame->v4l2_format.format == V4L2_PIX_FMT_YVU420) {
+                       *f++ = Y[idx];
+                       if (!((idx & 0x01) | (frame->curline & 0x01))) {
+                               /* only need do this for 1 in 4 pixels */
+                               /* intraframe buffer is YUV420 format */
+                               *u++ = U[idx >> 1];
+                               *v++ = V[idx >> 1];
                        }
-
-               }
-               else {
-                       YUV_TO_RGB_BY_THE_BOOK(Y[idx], U[idx/2], V[idx/2], rv, gv, bv);
+               } else {
+                       YUV_TO_RGB_BY_THE_BOOK(Y[idx], U[idx / 2], V[idx / 2], rv, gv, bv);
                        switch (frame->v4l2_format.format) {
-                               case V4L2_PIX_FMT_GREY:
-                                       *f++ = Y[idx];
-                                       break;
-                               case V4L2_PIX_FMT_RGB555:
-                                       *f++ = (0x1F & rv) |
-                                               (0xE0 & (gv << 5));
-                                       *f++ = (0x03 & (gv >> 3)) |
-                                               (0x7C & (bv << 2));
-                                       break;
-                               case V4L2_PIX_FMT_RGB565:
-                                       *f++ = (0x1F & rv) |
-                                               (0xE0 & (gv << 5));
-                                       *f++ = (0x07 & (gv >> 3)) |
-                                               (0xF8 &  bv);
-                                       break;
-                               case V4L2_PIX_FMT_RGB24:
-                                       *f++ = rv;
-                                       *f++ = gv;
-                                       *f++ = bv;
-                                       break;
-                               case V4L2_PIX_FMT_RGB32:
-                                       *f++ = rv;
-                                       *f++ = gv;
-                                       *f++ = bv;
-                                       f++;
-                                       break;
+                       case V4L2_PIX_FMT_GREY:
+                               *f++ = Y[idx];
+                               break;
+                       case V4L2_PIX_FMT_RGB555:
+                               *f++ = (0x1F & rv) |
+                                       (0xE0 & (gv << 5));
+                               *f++ = (0x03 & (gv >> 3)) |
+                                       (0x7C & (bv << 2));
+                               break;
+                       case V4L2_PIX_FMT_RGB565:
+                               *f++ = (0x1F & rv) |
+                                       (0xE0 & (gv << 5));
+                               *f++ = (0x07 & (gv >> 3)) |
+                                       (0xF8 & bv);
+                               break;
+                       case V4L2_PIX_FMT_RGB24:
+                               *f++ = rv;
+                               *f++ = gv;
+                               *f++ = bv;
+                               break;
+                       case V4L2_PIX_FMT_RGB32:
+                               *f++ = rv;
+                               *f++ = gv;
+                               *f++ = bv;
+                               f++;
+                               break;
                        }
                }
                clipmask_index++;
        }
        /* Deal with non-integer no. of bytes for YUV420P */
-       if (frame->v4l2_format.format != V4L2_PIX_FMT_YVU420 )
+       if (frame->v4l2_format.format != V4L2_PIX_FMT_YVU420)
                *pcopylen += frame->v4l2_linesize;
        else
                *pcopylen += frame->curline & 0x01 ? frame->v4l2_linesize : frame->v4l2_linesize << 1;
 
        frame->curline += 1;
 
-       if (frame->curline >= frame->frmheight) {
+       if (frame->curline >= frame->frmheight)
                return parse_state_next_frame;
-       }
-       else {
-               return parse_state_continue;
-       }
+       return parse_state_continue;
 
 }
 
@@ -1016,11 +969,11 @@ static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvisio
        unsigned int pixel_per_line, block;
        int pixel, block_split;
        int y_ptr, u_ptr, v_ptr, y_odd_offset;
-       const int   y_block_size = 128;
-       const int  uv_block_size = 64;
+       const int y_block_size = 128;
+       const int uv_block_size = 64;
        const int sub_block_size = 32;
-       const int y_step[] = { 0, 0, 0, 2 },  y_step_size = 4;
-       const int uv_step[]= { 0, 0, 0, 4 }, uv_step_size = 4;
+       const int y_step[] = { 0, 0, 0, 2 }, y_step_size = 4;
+       const int uv_step[] = { 0, 0, 0, 4 }, uv_step_size = 4;
        unsigned char y[2], u, v;       /* YUV components */
        int y_, u_, v_, vb, uvg, ur;
        int r_, g_, b_;                 /* RGB components */
@@ -1047,9 +1000,8 @@ static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvisio
                return parse_state_out;
        }
 
-       if ((frame->curline + 1) >= frame->frmheight) {
+       if ((frame->curline + 1) >= frame->frmheight)
                return parse_state_next_frame;
-       }
 
        block_split = (pixel_per_line%y_block_size) ? 1 : 0;    /* are some blocks splitted into different lines? */
 
@@ -1061,11 +1013,8 @@ static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvisio
        scratch_set_extra_ptr(usbvision, &v_ptr, y_odd_offset
                        + (4 - block_split) * sub_block_size);
 
-       for (block = 0; block < (pixel_per_line / sub_block_size);
-            block++) {
-
-
-               for (pixel = 0; pixel < sub_block_size; pixel +=2) {
+       for (block = 0; block < (pixel_per_line / sub_block_size); block++) {
+               for (pixel = 0; pixel < sub_block_size; pixel += 2) {
                        scratch_get(usbvision, &y[0], 2);
                        scratch_get_extra(usbvision, &u, &u_ptr, 1);
                        scratch_get_extra(usbvision, &v, &v_ptr, 1);
@@ -1073,19 +1022,18 @@ static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvisio
                        /* I don't use the YUV_TO_RGB macro for better performance */
                        v_ = v - 128;
                        u_ = u - 128;
-                       vb =              132252 * v_;
-                       uvg= -53281 * u_ - 25625 * v_;
+                       vb = 132252 * v_;
+                       uvg = -53281 * u_ - 25625 * v_;
                        ur = 104595 * u_;
 
-                       if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+                       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                                *f_even++ = y[0];
                                *f_even++ = v;
-                       }
-                       else {
+                       } else {
                                y_ = 76284 * (y[0] - 16);
 
                                b_ = (y_ + vb) >> 16;
-                               g_ = (y_ + uvg)>> 16;
+                               g_ = (y_ + uvg) >> 16;
                                r_ = (y_ + ur) >> 16;
 
                                switch (frame->v4l2_format.format) {
@@ -1121,15 +1069,14 @@ static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvisio
                        clipmask_even_index += clipmask_add;
                        f_even += stretch_bytes;
 
-                       if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+                       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                                *f_even++ = y[1];
                                *f_even++ = u;
-                       }
-                       else {
+                       } else {
                                y_ = 76284 * (y[1] - 16);
 
                                b_ = (y_ + vb) >> 16;
-                               g_ = (y_ + uvg)>> 16;
+                               g_ = (y_ + uvg) >> 16;
                                r_ = (y_ + ur) >> 16;
 
                                switch (frame->v4l2_format.format) {
@@ -1167,15 +1114,14 @@ static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvisio
 
                        scratch_get_extra(usbvision, &y[0], &y_ptr, 2);
 
-                       if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+                       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                                *f_odd++ = y[0];
                                *f_odd++ = v;
-                       }
-                       else {
+                       } else {
                                y_ = 76284 * (y[0] - 16);
 
                                b_ = (y_ + vb) >> 16;
-                               g_ = (y_ + uvg)>> 16;
+                               g_ = (y_ + uvg) >> 16;
                                r_ = (y_ + ur) >> 16;
 
                                switch (frame->v4l2_format.format) {
@@ -1211,15 +1157,14 @@ static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvisio
                        clipmask_odd_index += clipmask_add;
                        f_odd += stretch_bytes;
 
-                       if(frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
+                       if (frame->v4l2_format.format == V4L2_PIX_FMT_YUYV) {
                                *f_odd++ = y[1];
                                *f_odd++ = u;
-                       }
-                       else {
+                       } else {
                                y_ = 76284 * (y[1] - 16);
 
                                b_ = (y_ + vb) >> 16;
-                               g_ = (y_ + uvg)>> 16;
+                               g_ = (y_ + uvg) >> 16;
                                r_ = (y_ + ur) >> 16;
 
                                switch (frame->v4l2_format.format) {
@@ -1256,7 +1201,7 @@ static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvisio
                        f_odd += stretch_bytes;
                }
 
-               scratch_rm_old(usbvision,y_step[block % y_step_size] * sub_block_size);
+               scratch_rm_old(usbvision, y_step[block % y_step_size] * sub_block_size);
                scratch_inc_extra_ptr(&y_ptr, y_step[(block + 2 * block_split) % y_step_size]
                                * sub_block_size);
                scratch_inc_extra_ptr(&u_ptr, uv_step[block % uv_step_size]
@@ -1273,8 +1218,7 @@ static enum parse_state usbvision_parse_lines_420(struct usb_usbvision *usbvisio
 
        if (frame->curline >= frame->frmheight)
                return parse_state_next_frame;
-       else
-               return parse_state_continue;
+       return parse_state_continue;
 }
 
 /*
@@ -1297,34 +1241,24 @@ static void usbvision_parse_data(struct usb_usbvision *usbvision)
        PDEBUG(DBG_PARSE, "parsing len=%d\n", scratch_len(usbvision));
 
        while (1) {
-
                newstate = parse_state_out;
                if (scratch_len(usbvision)) {
                        if (frame->scanstate == scan_state_scanning) {
                                newstate = usbvision_find_header(usbvision);
-                       }
-                       else if (frame->scanstate == scan_state_lines) {
-                               if (usbvision->isoc_mode == ISOC_MODE_YUV420) {
+                       } else if (frame->scanstate == scan_state_lines) {
+                               if (usbvision->isoc_mode == ISOC_MODE_YUV420)
                                        newstate = usbvision_parse_lines_420(usbvision, &copylen);
-                               }
-                               else if (usbvision->isoc_mode == ISOC_MODE_YUV422) {
+                               else if (usbvision->isoc_mode == ISOC_MODE_YUV422)
                                        newstate = usbvision_parse_lines_422(usbvision, &copylen);
-                               }
-                               else if (usbvision->isoc_mode == ISOC_MODE_COMPRESS) {
+                               else if (usbvision->isoc_mode == ISOC_MODE_COMPRESS)
                                        newstate = usbvision_parse_compress(usbvision, &copylen);
-                               }
-
                        }
                }
-               if (newstate == parse_state_continue) {
+               if (newstate == parse_state_continue)
                        continue;
-               }
-               else if ((newstate == parse_state_next_frame) || (newstate == parse_state_out)) {
+               if ((newstate == parse_state_next_frame) || (newstate == parse_state_out))
                        break;
-               }
-               else {
-                       return; /* parse_state_end_parse */
-               }
+               return; /* parse_state_end_parse */
        }
 
        if (newstate == parse_state_next_frame) {
@@ -1344,10 +1278,9 @@ static void usbvision_parse_data(struct usb_usbvision *usbvision)
                        PDEBUG(DBG_PARSE, "Wake up !");
                        wake_up_interruptible(&usbvision->wait_frame);
                }
-       }
-       else
+       } else {
                frame->grabstate = frame_state_grabbing;
-
+       }
 
        /* Update the frame's uncompressed length. */
        frame->scanlength += copylen;
@@ -1381,14 +1314,12 @@ static int usbvision_compress_isochronous(struct usb_usbvision *usbvision,
                        PDEBUG(DBG_ISOC, "error packet [%d]", i);
                        usbvision->isoc_skip_count++;
                        continue;
-               }
-               else if (packet_len == 0) {     /* Frame end ????? */
+               } else if (packet_len == 0) {   /* Frame end ????? */
                        PDEBUG(DBG_ISOC, "null packet [%d]", i);
-                       usbvision->isocstate=isoc_state_no_frame;
+                       usbvision->isocstate = isoc_state_no_frame;
                        usbvision->isoc_skip_count++;
                        continue;
-               }
-               else if (packet_len > usbvision->isoc_packet_size) {
+               } else if (packet_len > usbvision->isoc_packet_size) {
                        PDEBUG(DBG_ISOC, "packet[%d] > isoc_packet_size", i);
                        usbvision->isoc_skip_count++;
                        continue;
@@ -1396,8 +1327,8 @@ static int usbvision_compress_isochronous(struct usb_usbvision *usbvision,
 
                PDEBUG(DBG_ISOC, "packet ok [%d] len=%d", i, packet_len);
 
-               if (usbvision->isocstate==isoc_state_no_frame) { /* new frame begins */
-                       usbvision->isocstate=isoc_state_in_frame;
+               if (usbvision->isocstate == isoc_state_no_frame) { /* new frame begins */
+                       usbvision->isocstate = isoc_state_in_frame;
                        scratch_mark_header(usbvision);
                        usbvision_measure_bandwidth(usbvision);
                        PDEBUG(DBG_ISOC, "packet with header");
@@ -1412,7 +1343,6 @@ static int usbvision_compress_isochronous(struct usb_usbvision *usbvision,
                 * your favorite evil here.
                 */
                if (scratch_free(usbvision) < packet_len) {
-
                        usbvision->scratch_ovf_count++;
                        PDEBUG(DBG_ISOC, "scratch buf overflow! scr_len: %d, n: %d",
                               scratch_len(usbvision), packet_len);
@@ -1428,6 +1358,7 @@ static int usbvision_compress_isochronous(struct usb_usbvision *usbvision,
 #if ENABLE_HEXDUMP
        if (totlen > 0) {
                static int foo;
+
                if (foo < 1) {
                        printk(KERN_DEBUG "+%d.\n", usbvision->scratchlen);
                        usbvision_hexdump(data0, (totlen > 64) ? 64 : totlen);
@@ -1435,7 +1366,7 @@ static int usbvision_compress_isochronous(struct usb_usbvision *usbvision,
                }
        }
 #endif
- return totlen;
      return totlen;
 }
 
 static void usbvision_isoc_irq(struct urb *urb)
@@ -1452,9 +1383,8 @@ static void usbvision_isoc_irq(struct urb *urb)
                return;
 
        /* any urb with wrong status is ignored without acknowledgement */
-       if (urb->status == -ENOENT) {
+       if (urb->status == -ENOENT)
                return;
-       }
 
        f = &usbvision->cur_frame;
 
@@ -1476,26 +1406,23 @@ static void usbvision_isoc_irq(struct urb *urb)
        usbvision->urb_length = len;
 
        if (usbvision->streaming == stream_on) {
-
                /* If we collected enough data let's parse! */
-               if ((scratch_len(usbvision) > USBVISION_HEADER_LENGTH) &&
-                   (!list_empty(&(usbvision->inqueue))) ) {
+               if (scratch_len(usbvision) > USBVISION_HEADER_LENGTH &&
+                   !list_empty(&(usbvision->inqueue))) {
                        if (!(*f)) {
                                (*f) = list_entry(usbvision->inqueue.next,
                                                  struct usbvision_frame,
                                                  frame);
                        }
                        usbvision_parse_data(usbvision);
-               }
-               else {
+               } else {
                        /* If we don't have a frame
                          we're current working on, complain */
                        PDEBUG(DBG_IRQ,
                               "received data, but no one needs it");
                        scratch_reset(usbvision);
                }
-       }
-       else {
+       } else {
                PDEBUG(DBG_IRQ, "received data, but no one needs it");
                scratch_reset(usbvision);
        }
@@ -1509,9 +1436,9 @@ static void usbvision_isoc_irq(struct urb *urb)
 
        urb->status = 0;
        urb->dev = usbvision->dev;
-       err_code = usb_submit_urb (urb, GFP_ATOMIC);
+       err_code = usb_submit_urb(urb, GFP_ATOMIC);
 
-       if(err_code) {
+       if (err_code) {
                dev_err(&usbvision->dev->dev,
                        "%s: usb_submit_urb failed: error %d\n",
                                __func__, err_code);
@@ -1587,24 +1514,21 @@ static void usbvision_ctrl_urb_complete(struct urb *urb)
 
        PDEBUG(DBG_IRQ, "");
        usbvision->ctrl_urb_busy = 0;
-       if (waitqueue_active(&usbvision->ctrl_urb_wq)) {
+       if (waitqueue_active(&usbvision->ctrl_urb_wq))
                wake_up_interruptible(&usbvision->ctrl_urb_wq);
-       }
 }
 
 
-static int usbvision_write_reg_irq(struct usb_usbvision *usbvision,int address,
-                                                                       unsigned char *data, int len)
+static int usbvision_write_reg_irq(struct usb_usbvision *usbvision, int address,
+                               unsigned char *data, int len)
 {
        int err_code = 0;
 
        PDEBUG(DBG_IRQ, "");
-       if (len > 8) {
+       if (len > 8)
                return -EFAULT;
-       }
-       if (usbvision->ctrl_urb_busy) {
+       if (usbvision->ctrl_urb_busy)
                return -EBUSY;
-       }
        usbvision->ctrl_urb_busy = 1;
 
        usbvision->ctrl_urb_setup.bRequestType = USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_ENDPOINT;
@@ -1612,7 +1536,7 @@ static int usbvision_write_reg_irq(struct usb_usbvision *usbvision,int address,
        usbvision->ctrl_urb_setup.wValue       = 0;
        usbvision->ctrl_urb_setup.wIndex       = cpu_to_le16(address);
        usbvision->ctrl_urb_setup.wLength      = cpu_to_le16(len);
-       usb_fill_control_urb (usbvision->ctrl_urb, usbvision->dev,
+       usb_fill_control_urb(usbvision->ctrl_urb, usbvision->dev,
                                                        usb_sndctrlpipe(usbvision->dev, 1),
                                                        (unsigned char *)&usbvision->ctrl_urb_setup,
                                                        (void *)usbvision->ctrl_urb_buffer, len,
@@ -1652,7 +1576,7 @@ static int usbvision_init_compression(struct usb_usbvision *usbvision)
  * return:    0 : no error
  * sets used_bandwidth to 1-100 : 1-100% of full bandwidth resp. to isoc_packet_size
  */
-static int usbvision_measure_bandwidth (struct usb_usbvision *usbvision)
+static int usbvision_measure_bandwidth(struct usb_usbvision *usbvision)
 {
        int err_code = 0;
 
@@ -1672,7 +1596,7 @@ static int usbvision_measure_bandwidth (struct usb_usbvision *usbvision)
        return err_code;
 }
 
-static int usbvision_adjust_compression (struct usb_usbvision *usbvision)
+static int usbvision_adjust_compression(struct usb_usbvision *usbvision)
 {
        int err_code = 0;
        unsigned char buffer[6];
@@ -1682,29 +1606,29 @@ static int usbvision_adjust_compression (struct usb_usbvision *usbvision)
                usbvision->compr_level += (usbvision->used_bandwidth - 90) / 2;
                RESTRICT_TO_RANGE(usbvision->compr_level, 0, 100);
                if (usbvision->compr_level != usbvision->last_compr_level) {
-                       int distorsion;
+                       int distortion;
+
                        if (usbvision->bridge_type == BRIDGE_NT1004 || usbvision->bridge_type == BRIDGE_NT1005) {
                                buffer[0] = (unsigned char)(4 + 16 * usbvision->compr_level / 100);     /* PCM Threshold 1 */
                                buffer[1] = (unsigned char)(4 + 8 * usbvision->compr_level / 100);      /* PCM Threshold 2 */
-                               distorsion = 7 + 248 * usbvision->compr_level / 100;
-                               buffer[2] = (unsigned char)(distorsion & 0xFF);                         /* Average distorsion Threshold (inter) */
-                               buffer[3] = (unsigned char)(distorsion & 0xFF);                         /* Average distorsion Threshold (intra) */
-                               distorsion = 1 + 42 * usbvision->compr_level / 100;
-                               buffer[4] = (unsigned char)(distorsion & 0xFF);                         /* Maximum distorsion Threshold (inter) */
-                               buffer[5] = (unsigned char)(distorsion & 0xFF);                         /* Maximum distorsion Threshold (intra) */
-                       }
-                       else { /* BRIDGE_NT1003 */
+                               distortion = 7 + 248 * usbvision->compr_level / 100;
+                               buffer[2] = (unsigned char)(distortion & 0xFF);                         /* Average distortion Threshold (inter) */
+                               buffer[3] = (unsigned char)(distortion & 0xFF);                         /* Average distortion Threshold (intra) */
+                               distortion = 1 + 42 * usbvision->compr_level / 100;
+                               buffer[4] = (unsigned char)(distortion & 0xFF);                         /* Maximum distortion Threshold (inter) */
+                               buffer[5] = (unsigned char)(distortion & 0xFF);                         /* Maximum distortion Threshold (intra) */
+                       } else { /* BRIDGE_NT1003 */
                                buffer[0] = (unsigned char)(4 + 16 * usbvision->compr_level / 100);     /* PCM threshold 1 */
                                buffer[1] = (unsigned char)(4 + 8 * usbvision->compr_level / 100);      /* PCM threshold 2 */
-                               distorsion = 2 + 253 * usbvision->compr_level / 100;
-                               buffer[2] = (unsigned char)(distorsion & 0xFF);                         /* distorsion threshold bit0-7 */
-                               buffer[3] = 0;  /* (unsigned char)((distorsion >> 8) & 0x0F);           distorsion threshold bit 8-11 */
-                               distorsion = 0 + 43 * usbvision->compr_level / 100;
-                               buffer[4] = (unsigned char)(distorsion & 0xFF);                         /* maximum distorsion bit0-7 */
-                               buffer[5] = 0; /* (unsigned char)((distorsion >> 8) & 0x01);            maximum distorsion bit 8 */
+                               distortion = 2 + 253 * usbvision->compr_level / 100;
+                               buffer[2] = (unsigned char)(distortion & 0xFF);                         /* distortion threshold bit0-7 */
+                               buffer[3] = 0;  /* (unsigned char)((distortion >> 8) & 0x0F);           distortion threshold bit 8-11 */
+                               distortion = 0 + 43 * usbvision->compr_level / 100;
+                               buffer[4] = (unsigned char)(distortion & 0xFF);                         /* maximum distortion bit0-7 */
+                               buffer[5] = 0; /* (unsigned char)((distortion >> 8) & 0x01);            maximum distortion bit 8 */
                        }
                        err_code = usbvision_write_reg_irq(usbvision, USBVISION_PCM_THR1, buffer, 6);
-                       if (err_code == 0){
+                       if (err_code == 0) {
                                PDEBUG(DBG_IRQ, "new compr params %#02x %#02x %#02x %#02x %#02x %#02x", buffer[0],
                                                                buffer[1], buffer[2], buffer[3], buffer[4], buffer[5]);
                                usbvision->last_compr_level = usbvision->compr_level;
@@ -1714,7 +1638,7 @@ static int usbvision_adjust_compression (struct usb_usbvision *usbvision)
        return err_code;
 }
 
-static int usbvision_request_intra (struct usb_usbvision *usbvision)
+static int usbvision_request_intra(struct usb_usbvision *usbvision)
 {
        int err_code = 0;
        unsigned char buffer[1];
@@ -1726,7 +1650,7 @@ static int usbvision_request_intra (struct usb_usbvision *usbvision)
        return err_code;
 }
 
-static int usbvision_unrequest_intra (struct usb_usbvision *usbvision)
+static int usbvision_unrequest_intra(struct usb_usbvision *usbvision)
 {
        int err_code = 0;
        unsigned char buffer[1];
@@ -1749,10 +1673,9 @@ int usbvision_power_off(struct usb_usbvision *usbvision)
        PDEBUG(DBG_FUNC, "");
 
        err_code = usbvision_write_reg(usbvision, USBVISION_PWR_REG, USBVISION_SSPND_EN);
-       if (err_code == 1) {
+       if (err_code == 1)
                usbvision->power = 0;
-       }
-       PDEBUG(DBG_FUNC, "%s: err_code %d", (err_code!=1)?"ERROR":"power is off", err_code);
+       PDEBUG(DBG_FUNC, "%s: err_code %d", (err_code != 1) ? "ERROR" : "power is off", err_code);
        return err_code;
 }
 
@@ -1804,18 +1727,16 @@ int usbvision_set_output(struct usb_usbvision *usbvision, int width,
 {
        int err_code = 0;
        int usb_width, usb_height;
-       unsigned int frame_rate=0, frame_drop=0;
+       unsigned int frame_rate = 0, frame_drop = 0;
        unsigned char value[4];
 
-       if (!USBVISION_IS_OPERATIONAL(usbvision)) {
+       if (!USBVISION_IS_OPERATIONAL(usbvision))
                return 0;
-       }
 
        if (width > MAX_USB_WIDTH) {
                usb_width = width / 2;
                usbvision->stretch_width = 2;
-       }
-       else {
+       } else {
                usb_width = width;
                usbvision->stretch_width = 1;
        }
@@ -1823,8 +1744,7 @@ int usbvision_set_output(struct usb_usbvision *usbvision, int width,
        if (height > MAX_USB_HEIGHT) {
                usb_height = height / 2;
                usbvision->stretch_height = 2;
-       }
-       else {
+       } else {
                usb_height = height;
                usbvision->stretch_height = 1;
        }
@@ -1859,28 +1779,23 @@ int usbvision_set_output(struct usb_usbvision *usbvision, int width,
                usbvision->curheight = usbvision->stretch_height * usb_height;
        }
 
-       if (usbvision->isoc_mode == ISOC_MODE_YUV422) {
+       if (usbvision->isoc_mode == ISOC_MODE_YUV422)
                frame_rate = (usbvision->isoc_packet_size * 1000) / (usb_width * usb_height * 2);
-       }
-       else if (usbvision->isoc_mode == ISOC_MODE_YUV420) {
+       else if (usbvision->isoc_mode == ISOC_MODE_YUV420)
                frame_rate = (usbvision->isoc_packet_size * 1000) / ((usb_width * usb_height * 12) / 8);
-       }
-       else {
+       else
                frame_rate = FRAMERATE_MAX;
-       }
 
-       if (usbvision->tvnorm_id & V4L2_STD_625_50) {
+       if (usbvision->tvnorm_id & V4L2_STD_625_50)
                frame_drop = frame_rate * 32 / 25 - 1;
-       }
-       else if (usbvision->tvnorm_id & V4L2_STD_525_60) {
+       else if (usbvision->tvnorm_id & V4L2_STD_525_60)
                frame_drop = frame_rate * 32 / 30 - 1;
-       }
 
        RESTRICT_TO_RANGE(frame_drop, FRAMERATE_MIN, FRAMERATE_MAX);
 
        PDEBUG(DBG_FUNC, "frame_rate %d fps, frame_drop %d", frame_rate, frame_drop);
 
-       frame_drop = FRAMERATE_MAX;     /* We can allow the maximum here, because dropping is controlled */
+       frame_drop = FRAMERATE_MAX;     /* We can allow the maximum here, because dropping is controlled */
 
        /* frame_drop = 7; => frame_phase = 1, 5, 9, 13, 17, 21, 25, 0, 4, 8, ...
                => frame_skip = 4;
@@ -1904,7 +1819,7 @@ int usbvision_frames_alloc(struct usb_usbvision *usbvision, int number_of_frames
        int i;
 
        /* needs to be page aligned cause the buffers can be mapped individually! */
-       usbvision->max_frame_size =  PAGE_ALIGN(usbvision->curwidth *
+       usbvision->max_frame_size = PAGE_ALIGN(usbvision->curwidth *
                                                usbvision->curheight *
                                                usbvision->palette.bytes_per_pixel);
 
@@ -1912,9 +1827,9 @@ int usbvision_frames_alloc(struct usb_usbvision *usbvision, int number_of_frames
        usbvision->num_frames = number_of_frames;
        while (usbvision->num_frames > 0) {
                usbvision->fbuf_size = usbvision->num_frames * usbvision->max_frame_size;
-               if((usbvision->fbuf = usbvision_rvmalloc(usbvision->fbuf_size))) {
+               usbvision->fbuf = usbvision_rvmalloc(usbvision->fbuf_size);
+               if (usbvision->fbuf)
                        break;
-               }
                usbvision->num_frames--;
        }
 
@@ -1937,7 +1852,8 @@ int usbvision_frames_alloc(struct usb_usbvision *usbvision, int number_of_frames
                usbvision->frame[i].height = usbvision->curheight;
                usbvision->frame[i].bytes_read = 0;
        }
-       PDEBUG(DBG_FUNC, "allocated %d frames (%d bytes per frame)",usbvision->num_frames,usbvision->max_frame_size);
+       PDEBUG(DBG_FUNC, "allocated %d frames (%d bytes per frame)",
+                       usbvision->num_frames, usbvision->max_frame_size);
        return usbvision->num_frames;
 }
 
@@ -1948,7 +1864,7 @@ int usbvision_frames_alloc(struct usb_usbvision *usbvision, int number_of_frames
 void usbvision_frames_free(struct usb_usbvision *usbvision)
 {
        /* Have to free all that memory */
-       PDEBUG(DBG_FUNC, "free %d frames",usbvision->num_frames);
+       PDEBUG(DBG_FUNC, "free %d frames", usbvision->num_frames);
 
        if (usbvision->fbuf != NULL) {
                usbvision_rvfree(usbvision->fbuf, usbvision->fbuf_size);
@@ -2033,18 +1949,17 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision)
        if (usbvision->bridge_type == BRIDGE_NT1004) {
                value[0] =  20; /* PCM Threshold 1 */
                value[1] =  12; /* PCM Threshold 2 */
-               value[2] = 255; /* Distorsion Threshold inter */
-               value[3] = 255; /* Distorsion Threshold intra */
-               value[4] =  43; /* Max Distorsion inter */
-               value[5] =  43; /* Max Distorsion intra */
-       }
-       else {
+               value[2] = 255; /* Distortion Threshold inter */
+               value[3] = 255; /* Distortion Threshold intra */
+               value[4] =  43; /* Max Distortion inter */
+               value[5] =  43; /* Max Distortion intra */
+       } else {
                value[0] =  20; /* PCM Threshold 1 */
                value[1] =  12; /* PCM Threshold 2 */
-               value[2] = 255; /* Distorsion Threshold d7-d0 */
-               value[3] =   0; /* Distorsion Threshold d11-d8 */
-               value[4] =  43; /* Max Distorsion d7-d0 */
-               value[5] =   0; /* Max Distorsion d8 */
+               value[2] = 255; /* Distortion Threshold d7-d0 */
+               value[3] =   0; /* Distortion Threshold d11-d8 */
+               value[4] =  43; /* Max Distortion d7-d0 */
+               value[5] =   0; /* Max Distortion d8 */
        }
 
        if (!USBVISION_IS_OPERATIONAL(usbvision))
@@ -2059,10 +1974,7 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision)
        if (rc < 0) {
                printk(KERN_ERR "%sERROR=%d. USBVISION stopped - "
                       "reconnect or reload driver.\n", proc, rc);
-               return rc;
        }
-
-
        return rc;
 }
 
@@ -2087,7 +1999,7 @@ int usbvision_set_input(struct usb_usbvision *usbvision)
        /* Set input format expected from decoder*/
        if (usbvision_device_data[usbvision->dev_model].vin_reg1_override) {
                value[0] = usbvision_device_data[usbvision->dev_model].vin_reg1;
-       } else if(usbvision_device_data[usbvision->dev_model].codec == CODEC_SAA7113) {
+       } else if (usbvision_device_data[usbvision->dev_model].codec == CODEC_SAA7113) {
                /* SAA7113 uses 8 bit output */
                value[0] = USBVISION_8_422_SYNC;
        } else {
@@ -2135,8 +2047,8 @@ int usbvision_set_input(struct usb_usbvision *usbvision)
        }
 
        if (usbvision_device_data[usbvision->dev_model].x_offset >= 0) {
-               value[4]=usbvision_device_data[usbvision->dev_model].x_offset & 0xff;
-               value[5]=(usbvision_device_data[usbvision->dev_model].x_offset & 0x0300) >> 8;
+               value[4] = usbvision_device_data[usbvision->dev_model].x_offset & 0xff;
+               value[5] = (usbvision_device_data[usbvision->dev_model].x_offset & 0x0300) >> 8;
        }
 
        if (adjust_x_offset != -1) {
@@ -2145,8 +2057,8 @@ int usbvision_set_input(struct usb_usbvision *usbvision)
        }
 
        if (usbvision_device_data[usbvision->dev_model].y_offset >= 0) {
-               value[6]=usbvision_device_data[usbvision->dev_model].y_offset & 0xff;
-               value[7]=(usbvision_device_data[usbvision->dev_model].y_offset & 0x0300) >> 8;
+               value[6] = usbvision_device_data[usbvision->dev_model].y_offset & 0xff;
+               value[7] = (usbvision_device_data[usbvision->dev_model].y_offset & 0x0300) >> 8;
        }
 
        if (adjust_y_offset != -1) {
@@ -2167,15 +2079,14 @@ int usbvision_set_input(struct usb_usbvision *usbvision)
 
        dvi_yuv_value = 0x00;   /* U comes after V, Ya comes after U/V, Yb comes after Yb */
 
-       if(usbvision_device_data[usbvision->dev_model].dvi_yuv_override){
+       if (usbvision_device_data[usbvision->dev_model].dvi_yuv_override) {
                dvi_yuv_value = usbvision_device_data[usbvision->dev_model].dvi_yuv;
-       }
-       else if(usbvision_device_data[usbvision->dev_model].codec == CODEC_SAA7113) {
-       /* This changes as the fine sync control changes. Further investigation necessary */
+       } else if (usbvision_device_data[usbvision->dev_model].codec == CODEC_SAA7113) {
+               /* This changes as the fine sync control changes. Further investigation necessary */
                dvi_yuv_value = 0x06;
        }
 
-       return (usbvision_write_reg(usbvision, USBVISION_DVI_YUV, dvi_yuv_value));
+       return usbvision_write_reg(usbvision, USBVISION_DVI_YUV, dvi_yuv_value);
 }
 
 
@@ -2204,8 +2115,7 @@ static int usbvision_set_dram_settings(struct usb_usbvision *usbvision)
                /* UR:  0x0E200-0x3FFFF = 204288 Words (1 Word = 2 Byte) */
                /* FDL: 0x00000-0x0E099 =  57498 Words */
                /* VDW: 0x0E3FF-0x3FFFF */
-       }
-       else {
+       } else {
                value[0] = 0x42;
                value[1] = 0x00;
                value[2] = 0xff;
@@ -2218,14 +2128,14 @@ static int usbvision_set_dram_settings(struct usb_usbvision *usbvision)
        /* These are the values of the address of the video buffer,
         * they have to be loaded into the USBVISION_DRM_PRM1-8
         *
-        * Start address of video output buffer for read:       drm_prm1-2 -> 0x00000
-        * End address of video output buffer for read:         drm_prm1-3 -> 0x1ffff
-        * Start address of video frame delay buffer:           drm_prm1-4 -> 0x20000
+        * Start address of video output buffer for read:       drm_prm1-2 -> 0x00000
+        * End address of video output buffer for read:         drm_prm1-3 -> 0x1ffff
+        * Start address of video frame delay buffer:           drm_prm1-4 -> 0x20000
         *    Only used in compressed mode
-        * End address of video frame delay buffer:             drm_prm1-5-6 -> 0x3ffff
+        * End address of video frame delay buffer:             drm_prm1-5-6 -> 0x3ffff
         *    Only used in compressed mode
-        * Start address of video output buffer for write:      drm_prm1-7 -> 0x00000
-        * End address of video output buffer for write:        drm_prm1-8 -> 0x1ffff
+        * Start address of video output buffer for write:      drm_prm1-7 -> 0x00000
+        * End address of video output buffer for write:        drm_prm1-8 -> 0x1ffff
         */
 
        if (!USBVISION_IS_OPERATIONAL(usbvision))
@@ -2243,8 +2153,9 @@ static int usbvision_set_dram_settings(struct usb_usbvision *usbvision)
        }
 
        /* Restart the video buffer logic */
-       if ((rc = usbvision_write_reg(usbvision, USBVISION_DRM_CONT, USBVISION_RES_UR |
-                                  USBVISION_RES_FDL | USBVISION_RES_VDW)) < 0)
+       rc = usbvision_write_reg(usbvision, USBVISION_DRM_CONT, USBVISION_RES_UR |
+                                  USBVISION_RES_FDL | USBVISION_RES_VDW);
+       if (rc < 0)
                return rc;
        rc = usbvision_write_reg(usbvision, USBVISION_DRM_CONT, 0x00);
 
@@ -2267,16 +2178,15 @@ int usbvision_power_on(struct usb_usbvision *usbvision)
 
        usbvision_write_reg(usbvision, USBVISION_PWR_REG, USBVISION_SSPND_EN);
        usbvision_write_reg(usbvision, USBVISION_PWR_REG,
-                        USBVISION_SSPND_EN | USBVISION_RES2);
+                       USBVISION_SSPND_EN | USBVISION_RES2);
 
        usbvision_write_reg(usbvision, USBVISION_PWR_REG,
-                        USBVISION_SSPND_EN | USBVISION_PWR_VID);
+                       USBVISION_SSPND_EN | USBVISION_PWR_VID);
        err_code = usbvision_write_reg(usbvision, USBVISION_PWR_REG,
-                                               USBVISION_SSPND_EN | USBVISION_PWR_VID | USBVISION_RES2);
-       if (err_code == 1) {
+                       USBVISION_SSPND_EN | USBVISION_PWR_VID | USBVISION_RES2);
+       if (err_code == 1)
                usbvision->power = 1;
-       }
-       PDEBUG(DBG_FUNC, "%s: err_code %d", (err_code<0)?"ERROR":"power is on", err_code);
+       PDEBUG(DBG_FUNC, "%s: err_code %d", (err_code < 0) ? "ERROR" : "power is on", err_code);
        return err_code;
 }
 
@@ -2294,7 +2204,7 @@ static void call_usbvision_power_off(struct work_struct *work)
        if (mutex_lock_interruptible(&usbvision->v4l2_lock))
                return;
 
-       if(usbvision->user == 0) {
+       if (usbvision->user == 0) {
                usbvision_i2c_unregister(usbvision);
 
                usbvision_power_off(usbvision);
@@ -2305,7 +2215,7 @@ static void call_usbvision_power_off(struct work_struct *work)
 
 static void usbvision_power_off_timer(unsigned long data)
 {
-       struct usb_usbvision *usbvision = (void *) data;
+       struct usb_usbvision *usbvision = (void *)data;
 
        PDEBUG(DBG_FUNC, "");
        del_timer(&usbvision->power_off_timer);
@@ -2316,7 +2226,7 @@ static void usbvision_power_off_timer(unsigned long data)
 void usbvision_init_power_off_timer(struct usb_usbvision *usbvision)
 {
        init_timer(&usbvision->power_off_timer);
-       usbvision->power_off_timer.data = (long) usbvision;
+       usbvision->power_off_timer.data = (long)usbvision;
        usbvision->power_off_timer.function = usbvision_power_off_timer;
 }
 
@@ -2327,9 +2237,8 @@ void usbvision_set_power_off_timer(struct usb_usbvision *usbvision)
 
 void usbvision_reset_power_off_timer(struct usb_usbvision *usbvision)
 {
-       if (timer_pending(&usbvision->power_off_timer)) {
+       if (timer_pending(&usbvision->power_off_timer))
                del_timer(&usbvision->power_off_timer);
-       }
 }
 
 /*
@@ -2339,14 +2248,10 @@ void usbvision_reset_power_off_timer(struct usb_usbvision *usbvision)
  */
 int usbvision_begin_streaming(struct usb_usbvision *usbvision)
 {
-       int err_code = 0;
-
-       if (usbvision->isoc_mode == ISOC_MODE_COMPRESS) {
+       if (usbvision->isoc_mode == ISOC_MODE_COMPRESS)
                usbvision_init_compression(usbvision);
-       }
-       err_code = usbvision_write_reg(usbvision, USBVISION_VIN_REG2, USBVISION_NOHVALID |
-                                                                               usbvision->vin_reg2_preset);
-       return err_code;
+       return usbvision_write_reg(usbvision, USBVISION_VIN_REG2,
+               USBVISION_NOHVALID | usbvision->vin_reg2_preset);
 }
 
 /*
@@ -2358,25 +2263,24 @@ int usbvision_restart_isoc(struct usb_usbvision *usbvision)
 {
        int ret;
 
-       if (
-           (ret =
-            usbvision_write_reg(usbvision, USBVISION_PWR_REG,
-                             USBVISION_SSPND_EN | USBVISION_PWR_VID)) < 0)
+       ret = usbvision_write_reg(usbvision, USBVISION_PWR_REG,
+                             USBVISION_SSPND_EN | USBVISION_PWR_VID);
+       if (ret < 0)
                return ret;
-       if (
-           (ret =
-            usbvision_write_reg(usbvision, USBVISION_PWR_REG,
+       ret = usbvision_write_reg(usbvision, USBVISION_PWR_REG,
                              USBVISION_SSPND_EN | USBVISION_PWR_VID |
-                             USBVISION_RES2)) < 0)
+                             USBVISION_RES2);
+       if (ret < 0)
                return ret;
-       if (
-           (ret =
-            usbvision_write_reg(usbvision, USBVISION_VIN_REG2,
+       ret = usbvision_write_reg(usbvision, USBVISION_VIN_REG2,
                              USBVISION_KEEP_BLANK | USBVISION_NOHVALID |
-                                 usbvision->vin_reg2_preset)) < 0) return ret;
+                                 usbvision->vin_reg2_preset);
+       if (ret < 0)
+               return ret;
 
        /* TODO: schedule timeout */
-       while ((usbvision_read_reg(usbvision, USBVISION_STATUS_REG) & 0x01) != 1);
+       while ((usbvision_read_reg(usbvision, USBVISION_STATUS_REG) & 0x01) != 1)
+               ;
 
        return 0;
 }
@@ -2384,7 +2288,7 @@ int usbvision_restart_isoc(struct usb_usbvision *usbvision)
 int usbvision_audio_off(struct usb_usbvision *usbvision)
 {
        if (usbvision_write_reg(usbvision, USBVISION_IOPIN_REG, USBVISION_AUDIO_MUTE) < 0) {
-               printk(KERN_ERR "usbvision_audio_off: can't wirte reg\n");
+               printk(KERN_ERR "usbvision_audio_off: can't write reg\n");
                return -1;
        }
        usbvision->audio_mute = 0;
@@ -2404,7 +2308,7 @@ int usbvision_set_audio(struct usb_usbvision *usbvision, int audio_channel)
        return 0;
 }
 
-int usbvision_setup(struct usb_usbvision *usbvision,int format)
+int usbvision_setup(struct usb_usbvision *usbvision, int format)
 {
        usbvision_set_video_format(usbvision, format);
        usbvision_set_dram_settings(usbvision);
@@ -2422,14 +2326,15 @@ int usbvision_set_alternate(struct usb_usbvision *dev)
        int err_code, prev_alt = dev->iface_alt;
        int i;
 
-       dev->iface_alt=0;
-       for(i=0;i< dev->num_alt; i++)
-               if(dev->alt_max_pkt_size[i]>dev->alt_max_pkt_size[dev->iface_alt])
-                       dev->iface_alt=i;
+       dev->iface_alt = 0;
+       for (i = 0; i < dev->num_alt; i++)
+               if (dev->alt_max_pkt_size[i] > dev->alt_max_pkt_size[dev->iface_alt])
+                       dev->iface_alt = i;
 
        if (dev->iface_alt != prev_alt) {
                dev->isoc_packet_size = dev->alt_max_pkt_size[dev->iface_alt];
-               PDEBUG(DBG_FUNC,"setting alternate %d with max_packet_size=%u", dev->iface_alt,dev->isoc_packet_size);
+               PDEBUG(DBG_FUNC, "setting alternate %d with max_packet_size=%u",
+                               dev->iface_alt, dev->isoc_packet_size);
                err_code = usb_set_interface(dev->dev, dev->iface, dev->iface_alt);
                if (err_code < 0) {
                        dev_err(&dev->dev->dev,
@@ -2549,7 +2454,7 @@ void usbvision_stop_isoc(struct usb_usbvision *usbvision)
        /* Unschedule all of the iso td's */
        for (buf_idx = 0; buf_idx < USBVISION_NUMSBUF; buf_idx++) {
                usb_kill_urb(usbvision->sbuf[buf_idx].urb);
-               if (usbvision->sbuf[buf_idx].data){
+               if (usbvision->sbuf[buf_idx].data) {
                        usb_free_coherent(usbvision->dev,
                                          sb_size,
                                          usbvision->sbuf[buf_idx].data,
@@ -2563,9 +2468,8 @@ void usbvision_stop_isoc(struct usb_usbvision *usbvision)
        usbvision->streaming = stream_off;
 
        if (!usbvision->remove_pending) {
-
                /* Set packet size to 0 */
-               usbvision->iface_alt=0;
+               usbvision->iface_alt = 0;
                err_code = usb_set_interface(usbvision->dev, usbvision->iface,
                                            usbvision->iface_alt);
                if (err_code < 0) {
@@ -2590,8 +2494,8 @@ int usbvision_muxsel(struct usb_usbvision *usbvision, int channel)
 {
        /* inputs #0 and #3 are constant for every SAA711x. */
        /* inputs #1 and #2 are variable for SAA7111 and SAA7113 */
-       int mode[4]= {SAA7115_COMPOSITE0, 0, 0, SAA7115_COMPOSITE3};
-       int audio[]= {1, 0, 0, 0};
+       int mode[4] = { SAA7115_COMPOSITE0, 0, 0, SAA7115_COMPOSITE3 };
+       int audio[] = { 1, 0, 0, 0 };
        /* channel 0 is TV with audiochannel 1 (tuner mono) */
        /* channel 1 is Composite with audio channel 0 (line in) */
        /* channel 2 is S-Video with audio channel 0 (line in) */
@@ -2605,24 +2509,23 @@ int usbvision_muxsel(struct usb_usbvision *usbvision, int channel)
        /* Four video input devices -> channel: 0 = Chan White, 1 = Chan Green, 2 = Chan Yellow, 3 = Chan Red */
 
        switch (usbvision_device_data[usbvision->dev_model].codec) {
-               case CODEC_SAA7113:
-                       mode[1] = SAA7115_COMPOSITE2;
-                       if (switch_svideo_input) {
-                               /* To handle problems with S-Video Input for
-                                * some devices.  Use switch_svideo_input
-                                * parameter when loading the module.*/
-                               mode[2] = SAA7115_COMPOSITE1;
-                       }
-                       else {
-                               mode[2] = SAA7115_SVIDEO1;
-                       }
-                       break;
-               case CODEC_SAA7111:
-               default:
-                       /* modes for saa7111 */
-                       mode[1] = SAA7115_COMPOSITE1;
+       case CODEC_SAA7113:
+               mode[1] = SAA7115_COMPOSITE2;
+               if (switch_svideo_input) {
+                       /* To handle problems with S-Video Input for
+                        * some devices.  Use switch_svideo_input
+                        * parameter when loading the module.*/
+                       mode[2] = SAA7115_COMPOSITE1;
+               } else {
                        mode[2] = SAA7115_SVIDEO1;
-                       break;
+               }
+               break;
+       case CODEC_SAA7111:
+       default:
+               /* modes for saa7111 */
+               mode[1] = SAA7115_COMPOSITE1;
+               mode[2] = SAA7115_SVIDEO1;
+               break;
        }
        call_all(usbvision, video, s_routing, mode[channel], 0, 0);
        usbvision_set_audio(usbvision, audio[channel]);
index cb19c84..05b1344 100644 (file)
 #include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/init.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 #include <linux/ioport.h>
 #include <linux/errno.h>
 #include <linux/usb.h>
 #include <linux/i2c.h>
 #include "usbvision.h"
 
-#define DBG_I2C                1<<0
+#define DBG_I2C                (1 << 0)
 
 static int i2c_debug;
 
-module_param (i2c_debug, int, 0644);                   /* debug_i2c_usb mode of the device driver */
+module_param(i2c_debug, int, 0644);                    /* debug_i2c_usb mode of the device driver */
 MODULE_PARM_DESC(i2c_debug, "enable debug messages [i2c]");
 
 #define PDEBUG(level, fmt, args...) { \
@@ -72,8 +72,8 @@ static inline int try_write_address(struct i2c_adapter *i2c_adap,
                udelay(10);
        }
        if (i) {
-               PDEBUG(DBG_I2C,"Needed %d retries for address %#2x", i, addr);
-               PDEBUG(DBG_I2C,"Maybe there's no device at this address");
+               PDEBUG(DBG_I2C, "Needed %d retries for address %#2x", i, addr);
+               PDEBUG(DBG_I2C, "Maybe there's no device at this address");
        }
        return ret;
 }
@@ -96,8 +96,8 @@ static inline int try_read_address(struct i2c_adapter *i2c_adap,
                udelay(10);
        }
        if (i) {
-               PDEBUG(DBG_I2C,"Needed %d retries for address %#2x", i, addr);
-               PDEBUG(DBG_I2C,"Maybe there's no device at this address");
+               PDEBUG(DBG_I2C, "Needed %d retries for address %#2x", i, addr);
+               PDEBUG(DBG_I2C, "Maybe there's no device at this address");
        }
        return ret;
 }
@@ -143,9 +143,8 @@ static inline int usb_find_address(struct i2c_adapter *i2c_adap,
                else
                        ret = try_write_address(i2c_adap, addr, retries);
 
-               if (ret != 1) {
+               if (ret != 1)
                        return -EREMOTEIO;
-               }
        }
        return 0;
 }
@@ -164,22 +163,20 @@ usbvision_i2c_xfer(struct i2c_adapter *i2c_adap, struct i2c_msg msgs[], int num)
                pmsg = &msgs[i];
                ret = usb_find_address(i2c_adap, pmsg, i2c_adap->retries, &addr);
                if (ret != 0) {
-                       PDEBUG(DBG_I2C,"got NAK from device, message #%d", i);
+                       PDEBUG(DBG_I2C, "got NAK from device, message #%d", i);
                        return (ret < 0) ? ret : -EREMOTEIO;
                }
 
                if (pmsg->flags & I2C_M_RD) {
                        /* read bytes into buffer */
                        ret = (usbvision_i2c_read(usbvision, addr, pmsg->buf, pmsg->len));
-                       if (ret < pmsg->len) {
+                       if (ret < pmsg->len)
                                return (ret < 0) ? ret : -EREMOTEIO;
-                       }
                } else {
                        /* write bytes from buffer */
                        ret = (usbvision_i2c_write(usbvision, addr, pmsg->buf, pmsg->len));
-                       if (ret < pmsg->len) {
+                       if (ret < pmsg->len)
                                return (ret < 0) ? ret : -EREMOTEIO;
-                       }
                }
        }
        return num;
@@ -219,7 +216,7 @@ int usbvision_i2c_register(struct usb_usbvision *usbvision)
 
        sprintf(usbvision->i2c_adap.name, "%s-%d-%s", i2c_adap_template.name,
                usbvision->dev->bus->busnum, usbvision->dev->devpath);
-       PDEBUG(DBG_I2C,"Adaptername: %s", usbvision->i2c_adap.name);
+       PDEBUG(DBG_I2C, "Adaptername: %s", usbvision->i2c_adap.name);
        usbvision->i2c_adap.dev.parent = &usbvision->dev->dev;
 
        i2c_set_adapdata(&usbvision->i2c_adap, &usbvision->v4l2_dev);
@@ -293,7 +290,7 @@ int usbvision_i2c_unregister(struct usb_usbvision *usbvision)
        i2c_del_adapter(&(usbvision->i2c_adap));
        usbvision->registered_i2c = 0;
 
-       PDEBUG(DBG_I2C,"i2c bus for %s unregistered", usbvision->i2c_adap.name);
+       PDEBUG(DBG_I2C, "i2c bus for %s unregistered", usbvision->i2c_adap.name);
 
        return 0;
 }
@@ -355,9 +352,9 @@ usbvision_i2c_read_max4(struct usb_usbvision *usbvision, unsigned char addr,
 
        if (i2c_debug & DBG_I2C) {
                int idx;
-               for (idx = 0; idx < len; idx++) {
-                       PDEBUG(DBG_I2C,"read %x from address %x", (unsigned char)buf[idx], addr);
-               }
+
+               for (idx = 0; idx < len; idx++)
+                       PDEBUG(DBG_I2C, "read %x from address %x", (unsigned char)buf[idx], addr);
        }
        return len;
 }
@@ -416,9 +413,9 @@ static int usbvision_i2c_write_max4(struct usb_usbvision *usbvision,
 
        if (i2c_debug & DBG_I2C) {
                int idx;
-               for (idx = 0; idx < len; idx++) {
-                       PDEBUG(DBG_I2C,"wrote %x at address %x", (unsigned char)buf[idx], addr);
-               }
+
+               for (idx = 0; idx < len; idx++)
+                       PDEBUG(DBG_I2C, "wrote %x at address %x", (unsigned char)buf[idx], addr);
        }
        return len;
 }
index 375355a..6083137 100644 (file)
@@ -56,7 +56,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/spinlock.h>
-#include <asm/io.h>
+#include <linux/io.h>
 #include <linux/videodev2.h>
 #include <linux/i2c.h>
 
@@ -70,8 +70,8 @@
 #include "usbvision.h"
 #include "usbvision-cards.h"
 
-#define DRIVER_AUTHOR "Joerg Heckenbach <joerg@heckenbach-aw.de>,\
- Dwaine Garden <DwaineGarden@rogers.com>"
+#define DRIVER_AUTHOR "Joerg Heckenbach <joerg@heckenbach-aw.de>, \
+Dwaine Garden <DwaineGarden@rogers.com>"
 #define DRIVER_NAME "usbvision"
 #define DRIVER_ALIAS "USBVision"
 #define DRIVER_DESC "USBVision USB Video Device Driver for Linux"
@@ -82,9 +82,9 @@
 #define USBVISION_DRIVER_VERSION KERNEL_VERSION(USBVISION_DRIVER_VERSION_MAJOR,\
 USBVISION_DRIVER_VERSION_MINOR,\
 USBVISION_DRIVER_VERSION_PATCHLEVEL)
-#define USBVISION_VERSION_STRING __stringify(USBVISION_DRIVER_VERSION_MAJOR)\
- "." __stringify(USBVISION_DRIVER_VERSION_MINOR)\
- "." __stringify(USBVISION_DRIVER_VERSION_PATCHLEVEL)
+#define USBVISION_VERSION_STRING __stringify(USBVISION_DRIVER_VERSION_MAJOR) \
+"." __stringify(USBVISION_DRIVER_VERSION_MINOR) \
+"." __stringify(USBVISION_DRIVER_VERSION_PATCHLEVEL)
 
 #define        ENABLE_HEXDUMP  0       /* Enable if you need it */
 
@@ -96,16 +96,16 @@ USBVISION_DRIVER_VERSION_PATCHLEVEL)
                                __func__, __LINE__ , ## args); \
        }
 #else
-       #define PDEBUG(level, fmt, args...) do {} while(0)
+       #define PDEBUG(level, fmt, args...) do {} while (0)
 #endif
 
-#define DBG_IO         1<<1
-#define DBG_PROBE      1<<2
-#define DBG_MMAP       1<<3
+#define DBG_IO         (1 << 1)
+#define DBG_PROBE      (1 << 2)
+#define DBG_MMAP       (1 << 3)
 
 /* String operations */
-#define rmspace(str)   while(*str==' ') str++;
-#define goto2next(str) while(*str!=' ') str++; while(*str==' ') str++;
+#define rmspace(str)   while (*str == ' ') str++;
+#define goto2next(str) while (*str != ' ') str++; while (*str == ' ') str++;
 
 
 /* sequential number of usbvision device */
@@ -205,7 +205,7 @@ static ssize_t show_hue(struct device *cd,
        struct v4l2_control ctrl;
        ctrl.id = V4L2_CID_HUE;
        ctrl.value = 0;
-       if(usbvision->user)
+       if (usbvision->user)
                call_all(usbvision, core, g_ctrl, &ctrl);
        return sprintf(buf, "%d\n", ctrl.value);
 }
@@ -220,7 +220,7 @@ static ssize_t show_contrast(struct device *cd,
        struct v4l2_control ctrl;
        ctrl.id = V4L2_CID_CONTRAST;
        ctrl.value = 0;
-       if(usbvision->user)
+       if (usbvision->user)
                call_all(usbvision, core, g_ctrl, &ctrl);
        return sprintf(buf, "%d\n", ctrl.value);
 }
@@ -235,7 +235,7 @@ static ssize_t show_brightness(struct device *cd,
        struct v4l2_control ctrl;
        ctrl.id = V4L2_CID_BRIGHTNESS;
        ctrl.value = 0;
-       if(usbvision->user)
+       if (usbvision->user)
                call_all(usbvision, core, g_ctrl, &ctrl);
        return sprintf(buf, "%d\n", ctrl.value);
 }
@@ -250,7 +250,7 @@ static ssize_t show_saturation(struct device *cd,
        struct v4l2_control ctrl;
        ctrl.id = V4L2_CID_SATURATION;
        ctrl.value = 0;
-       if(usbvision->user)
+       if (usbvision->user)
                call_all(usbvision, core, g_ctrl, &ctrl);
        return sprintf(buf, "%d\n", ctrl.value);
 }
@@ -263,7 +263,7 @@ static ssize_t show_streaming(struct device *cd,
                container_of(cd, struct video_device, dev);
        struct usb_usbvision *usbvision = video_get_drvdata(vdev);
        return sprintf(buf, "%s\n",
-                      YES_NO(usbvision->streaming==stream_on?1:0));
+                      YES_NO(usbvision->streaming == stream_on ? 1 : 0));
 }
 static DEVICE_ATTR(streaming, S_IRUGO, show_streaming, NULL);
 
@@ -274,7 +274,7 @@ static ssize_t show_compression(struct device *cd,
                container_of(cd, struct video_device, dev);
        struct usb_usbvision *usbvision = video_get_drvdata(vdev);
        return sprintf(buf, "%s\n",
-                      YES_NO(usbvision->isoc_mode==ISOC_MODE_COMPRESS));
+                      YES_NO(usbvision->isoc_mode == ISOC_MODE_COMPRESS));
 }
 static DEVICE_ATTR(compression, S_IRUGO, show_compression, NULL);
 
@@ -291,35 +291,36 @@ static DEVICE_ATTR(bridge, S_IRUGO, show_device_bridge, NULL);
 static void usbvision_create_sysfs(struct video_device *vdev)
 {
        int res;
+
        if (!vdev)
                return;
        do {
                res = device_create_file(&vdev->dev, &dev_attr_version);
-               if (res<0)
+               if (res < 0)
                        break;
                res = device_create_file(&vdev->dev, &dev_attr_model);
-               if (res<0)
+               if (res < 0)
                        break;
                res = device_create_file(&vdev->dev, &dev_attr_hue);
-               if (res<0)
+               if (res < 0)
                        break;
                res = device_create_file(&vdev->dev, &dev_attr_contrast);
-               if (res<0)
+               if (res < 0)
                        break;
                res = device_create_file(&vdev->dev, &dev_attr_brightness);
-               if (res<0)
+               if (res < 0)
                        break;
                res = device_create_file(&vdev->dev, &dev_attr_saturation);
-               if (res<0)
+               if (res < 0)
                        break;
                res = device_create_file(&vdev->dev, &dev_attr_streaming);
-               if (res<0)
+               if (res < 0)
                        break;
                res = device_create_file(&vdev->dev, &dev_attr_compression);
-               if (res<0)
+               if (res < 0)
                        break;
                res = device_create_file(&vdev->dev, &dev_attr_bridge);
-               if (res>=0)
+               if (res >= 0)
                        return;
        } while (0);
 
@@ -363,7 +364,7 @@ static int usbvision_v4l2_open(struct file *file)
        else {
                /* Allocate memory for the scratch ring buffer */
                err_code = usbvision_scratch_alloc(usbvision);
-               if (isoc_mode==ISOC_MODE_COMPRESS) {
+               if (isoc_mode == ISOC_MODE_COMPRESS) {
                        /* Allocate intermediate decompression buffers
                           only if needed */
                        err_code = usbvision_decompress_alloc(usbvision);
@@ -385,7 +386,7 @@ static int usbvision_v4l2_open(struct file *file)
                /* Send init sequence only once, it's large! */
                if (!usbvision->initialized) {
                        int setup_ok = 0;
-                       setup_ok = usbvision_setup(usbvision,isoc_mode);
+                       setup_ok = usbvision_setup(usbvision, isoc_mode);
                        if (setup_ok)
                                usbvision->initialized = 1;
                        else
@@ -396,7 +397,7 @@ static int usbvision_v4l2_open(struct file *file)
                        usbvision_begin_streaming(usbvision);
                        err_code = usbvision_init_isoc(usbvision);
                        /* device must be initialized before isoc transfer */
-                       usbvision_muxsel(usbvision,0);
+                       usbvision_muxsel(usbvision, 0);
                        usbvision->user++;
                } else {
                        if (power_on_at_open) {
@@ -463,7 +464,7 @@ static int usbvision_v4l2_close(struct file *file)
  *
  */
 #ifdef CONFIG_VIDEO_ADV_DEBUG
-static int vidioc_g_register (struct file *file, void *priv,
+static int vidioc_g_register(struct file *file, void *priv,
                                struct v4l2_dbg_register *reg)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
@@ -484,7 +485,7 @@ static int vidioc_g_register (struct file *file, void *priv,
        return 0;
 }
 
-static int vidioc_s_register (struct file *file, void *priv,
+static int vidioc_s_register(struct file *file, void *priv,
                                struct v4l2_dbg_register *reg)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
@@ -493,7 +494,7 @@ static int vidioc_s_register (struct file *file, void *priv,
        if (!v4l2_chip_match_host(&reg->match))
                return -EINVAL;
        /* NT100x has a 8-bit register space */
-       err_code = usbvision_write_reg(usbvision, reg->reg&0xff, reg->val);
+       err_code = usbvision_write_reg(usbvision, reg->reg & 0xff, reg->val);
        if (err_code < 0) {
                dev_err(&usbvision->vdev->dev,
                        "%s: VIDIOC_DBG_S_REGISTER failed: error %d\n",
@@ -504,7 +505,7 @@ static int vidioc_s_register (struct file *file, void *priv,
 }
 #endif
 
-static int vidioc_querycap (struct file *file, void  *priv,
+static int vidioc_querycap(struct file *file, void  *priv,
                                        struct v4l2_capability *vc)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
@@ -523,7 +524,7 @@ static int vidioc_querycap (struct file *file, void  *priv,
        return 0;
 }
 
-static int vidioc_enum_input (struct file *file, void *priv,
+static int vidioc_enum_input(struct file *file, void *priv,
                                struct v4l2_input *vi)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
@@ -531,14 +532,14 @@ static int vidioc_enum_input (struct file *file, void *priv,
 
        if (vi->index >= usbvision->video_inputs)
                return -EINVAL;
-       if (usbvision->have_tuner) {
+       if (usbvision->have_tuner)
                chan = vi->index;
-       } else {
+       else
                chan = vi->index + 1; /* skip Television string*/
-       }
+
        /* Determine the requested input characteristics
           specific for each usbvision card model */
-       switch(chan) {
+       switch (chan) {
        case 0:
                if (usbvision_device_data[usbvision->dev_model].video_channels == 4) {
                        strcpy(vi->name, "White Video Input");
@@ -552,20 +553,18 @@ static int vidioc_enum_input (struct file *file, void *priv,
                break;
        case 1:
                vi->type = V4L2_INPUT_TYPE_CAMERA;
-               if (usbvision_device_data[usbvision->dev_model].video_channels == 4) {
+               if (usbvision_device_data[usbvision->dev_model].video_channels == 4)
                        strcpy(vi->name, "Green Video Input");
-               } else {
+               else
                        strcpy(vi->name, "Composite Video Input");
-               }
                vi->std = V4L2_STD_PAL;
                break;
        case 2:
                vi->type = V4L2_INPUT_TYPE_CAMERA;
-               if (usbvision_device_data[usbvision->dev_model].video_channels == 4) {
+               if (usbvision_device_data[usbvision->dev_model].video_channels == 4)
                        strcpy(vi->name, "Yellow Video Input");
-               } else {
+               else
                        strcpy(vi->name, "S-Video Input");
-               }
                vi->std = V4L2_STD_PAL;
                break;
        case 3:
@@ -577,7 +576,7 @@ static int vidioc_enum_input (struct file *file, void *priv,
        return 0;
 }
 
-static int vidioc_g_input (struct file *file, void *priv, unsigned int *input)
+static int vidioc_g_input(struct file *file, void *priv, unsigned int *input)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
 
@@ -585,7 +584,7 @@ static int vidioc_g_input (struct file *file, void *priv, unsigned int *input)
        return 0;
 }
 
-static int vidioc_s_input (struct file *file, void *priv, unsigned int input)
+static int vidioc_s_input(struct file *file, void *priv, unsigned int input)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
 
@@ -600,11 +599,11 @@ static int vidioc_s_input (struct file *file, void *priv, unsigned int input)
        return 0;
 }
 
-static int vidioc_s_std (struct file *file, void *priv, v4l2_std_id *id)
+static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id *id)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
 
-       usbvision->tvnorm_id=*id;
+       usbvision->tvnorm_id = *id;
 
        call_all(usbvision, core, s_std, usbvision->tvnorm_id);
        /* propagate the change to the decoder */
@@ -613,14 +612,14 @@ static int vidioc_s_std (struct file *file, void *priv, v4l2_std_id *id)
        return 0;
 }
 
-static int vidioc_g_tuner (struct file *file, void *priv,
+static int vidioc_g_tuner(struct file *file, void *priv,
                                struct v4l2_tuner *vt)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
 
        if (!usbvision->have_tuner || vt->index)        /* Only tuner 0 */
                return -EINVAL;
-       if(usbvision->radio) {
+       if (usbvision->radio) {
                strcpy(vt->name, "Radio");
                vt->type = V4L2_TUNER_RADIO;
        } else {
@@ -632,7 +631,7 @@ static int vidioc_g_tuner (struct file *file, void *priv,
        return 0;
 }
 
-static int vidioc_s_tuner (struct file *file, void *priv,
+static int vidioc_s_tuner(struct file *file, void *priv,
                                struct v4l2_tuner *vt)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
@@ -646,23 +645,22 @@ static int vidioc_s_tuner (struct file *file, void *priv,
        return 0;
 }
 
-static int vidioc_g_frequency (struct file *file, void *priv,
+static int vidioc_g_frequency(struct file *file, void *priv,
                                struct v4l2_frequency *freq)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
 
        freq->tuner = 0; /* Only one tuner */
-       if(usbvision->radio) {
+       if (usbvision->radio)
                freq->type = V4L2_TUNER_RADIO;
-       } else {
+       else
                freq->type = V4L2_TUNER_ANALOG_TV;
-       }
        freq->frequency = usbvision->freq;
 
        return 0;
 }
 
-static int vidioc_s_frequency (struct file *file, void *priv,
+static int vidioc_s_frequency(struct file *file, void *priv,
                                struct v4l2_frequency *freq)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
@@ -677,30 +675,27 @@ static int vidioc_s_frequency (struct file *file, void *priv,
        return 0;
 }
 
-static int vidioc_g_audio (struct file *file, void *priv, struct v4l2_audio *a)
+static int vidioc_g_audio(struct file *file, void *priv, struct v4l2_audio *a)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
 
-       if(usbvision->radio) {
-               strcpy(a->name,"Radio");
-       } else {
+       if (usbvision->radio)
+               strcpy(a->name, "Radio");
+       else
                strcpy(a->name, "TV");
-       }
 
        return 0;
 }
 
-static int vidioc_s_audio (struct file *file, void *fh,
+static int vidioc_s_audio(struct file *file, void *fh,
                          struct v4l2_audio *a)
 {
-       if(a->index) {
+       if (a->index)
                return -EINVAL;
-       }
-
        return 0;
 }
 
-static int vidioc_queryctrl (struct file *file, void *priv,
+static int vidioc_queryctrl(struct file *file, void *priv,
                            struct v4l2_queryctrl *ctrl)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
@@ -713,52 +708,53 @@ static int vidioc_queryctrl (struct file *file, void *priv,
        return 0;
 }
 
-static int vidioc_g_ctrl (struct file *file, void *priv,
+static int vidioc_g_ctrl(struct file *file, void *priv,
                                struct v4l2_control *ctrl)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
-       call_all(usbvision, core, g_ctrl, ctrl);
 
+       call_all(usbvision, core, g_ctrl, ctrl);
        return 0;
 }
 
-static int vidioc_s_ctrl (struct file *file, void *priv,
+static int vidioc_s_ctrl(struct file *file, void *priv,
                                struct v4l2_control *ctrl)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
-       call_all(usbvision, core, s_ctrl, ctrl);
 
+       call_all(usbvision, core, s_ctrl, ctrl);
        return 0;
 }
 
-static int vidioc_reqbufs (struct file *file,
+static int vidioc_reqbufs(struct file *file,
                           void *priv, struct v4l2_requestbuffers *vr)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
        int ret;
 
-       RESTRICT_TO_RANGE(vr->count,1,USBVISION_NUMFRAMES);
+       RESTRICT_TO_RANGE(vr->count, 1, USBVISION_NUMFRAMES);
 
        /* Check input validity:
           the user must do a VIDEO CAPTURE and MMAP method. */
        if (vr->memory != V4L2_MEMORY_MMAP)
                return -EINVAL;
 
-       if(usbvision->streaming == stream_on) {
-               if ((ret = usbvision_stream_interrupt(usbvision)))
+       if (usbvision->streaming == stream_on) {
+               ret = usbvision_stream_interrupt(usbvision);
+               if (ret)
                        return ret;
        }
 
        usbvision_frames_free(usbvision);
        usbvision_empty_framequeues(usbvision);
-       vr->count = usbvision_frames_alloc(usbvision,vr->count);
+       vr->count = usbvision_frames_alloc(usbvision, vr->count);
 
        usbvision->cur_frame = NULL;
 
        return 0;
 }
 
-static int vidioc_querybuf (struct file *file,
+static int vidioc_querybuf(struct file *file,
                            void *priv, struct v4l2_buffer *vb)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
@@ -766,48 +762,45 @@ static int vidioc_querybuf (struct file *file,
 
        /* FIXME : must control
           that buffers are mapped (VIDIOC_REQBUFS has been called) */
-       if(vb->index>=usbvision->num_frames)  {
+       if (vb->index >= usbvision->num_frames)
                return -EINVAL;
-       }
        /* Updating the corresponding frame state */
        vb->flags = 0;
        frame = &usbvision->frame[vb->index];
-       if(frame->grabstate >= frame_state_ready)
+       if (frame->grabstate >= frame_state_ready)
                vb->flags |= V4L2_BUF_FLAG_QUEUED;
-       if(frame->grabstate >= frame_state_done)
+       if (frame->grabstate >= frame_state_done)
                vb->flags |= V4L2_BUF_FLAG_DONE;
-       if(frame->grabstate == frame_state_unused)
+       if (frame->grabstate == frame_state_unused)
                vb->flags |= V4L2_BUF_FLAG_MAPPED;
        vb->memory = V4L2_MEMORY_MMAP;
 
-       vb->m.offset = vb->index*PAGE_ALIGN(usbvision->max_frame_size);
+       vb->m.offset = vb->index * PAGE_ALIGN(usbvision->max_frame_size);
 
        vb->memory = V4L2_MEMORY_MMAP;
        vb->field = V4L2_FIELD_NONE;
-       vb->length = usbvision->curwidth*
-               usbvision->curheight*
+       vb->length = usbvision->curwidth *
+               usbvision->curheight *
                usbvision->palette.bytes_per_pixel;
        vb->timestamp = usbvision->frame[vb->index].timestamp;
        vb->sequence = usbvision->frame[vb->index].sequence;
        return 0;
 }
 
-static int vidioc_qbuf (struct file *file, void *priv, struct v4l2_buffer *vb)
+static int vidioc_qbuf(struct file *file, void *priv, struct v4l2_buffer *vb)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
        struct usbvision_frame *frame;
        unsigned long lock_flags;
 
        /* FIXME : works only on VIDEO_CAPTURE MODE, MMAP. */
-       if(vb->index>=usbvision->num_frames)  {
+       if (vb->index >= usbvision->num_frames)
                return -EINVAL;
-       }
 
        frame = &usbvision->frame[vb->index];
 
-       if (frame->grabstate != frame_state_unused) {
+       if (frame->grabstate != frame_state_unused)
                return -EAGAIN;
-       }
 
        /* Mark it as ready and enqueue frame */
        frame->grabstate = frame_state_ready;
@@ -826,7 +819,7 @@ static int vidioc_qbuf (struct file *file, void *priv, struct v4l2_buffer *vb)
        return 0;
 }
 
-static int vidioc_dqbuf (struct file *file, void *priv, struct v4l2_buffer *vb)
+static int vidioc_dqbuf(struct file *file, void *priv, struct v4l2_buffer *vb)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
        int ret;
@@ -882,7 +875,7 @@ static int vidioc_streamoff(struct file *file,
        if (type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
                return -EINVAL;
 
-       if(usbvision->streaming == stream_on) {
+       if (usbvision->streaming == stream_on) {
                usbvision_stream_interrupt(usbvision);
                /* Stop all video streamings */
                call_all(usbvision, video, s_stream, 0);
@@ -892,18 +885,17 @@ static int vidioc_streamoff(struct file *file,
        return 0;
 }
 
-static int vidioc_enum_fmt_vid_cap (struct file *file, void  *priv,
+static int vidioc_enum_fmt_vid_cap(struct file *file, void  *priv,
                                        struct v4l2_fmtdesc *vfd)
 {
-       if(vfd->index>=USBVISION_SUPPORTED_PALETTES-1) {
+       if (vfd->index >= USBVISION_SUPPORTED_PALETTES - 1)
                return -EINVAL;
-       }
-       strcpy(vfd->description,usbvision_v4l2_format[vfd->index].desc);
+       strcpy(vfd->description, usbvision_v4l2_format[vfd->index].desc);
        vfd->pixelformat = usbvision_v4l2_format[vfd->index].format;
        return 0;
 }
 
-static int vidioc_g_fmt_vid_cap (struct file *file, void *priv,
+static int vidioc_g_fmt_vid_cap(struct file *file, void *priv,
                                        struct v4l2_format *vf)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
@@ -911,32 +903,31 @@ static int vidioc_g_fmt_vid_cap (struct file *file, void *priv,
        vf->fmt.pix.height = usbvision->curheight;
        vf->fmt.pix.pixelformat = usbvision->palette.format;
        vf->fmt.pix.bytesperline =
-               usbvision->curwidth*usbvision->palette.bytes_per_pixel;
-       vf->fmt.pix.sizeimage = vf->fmt.pix.bytesperline*usbvision->curheight;
+               usbvision->curwidth * usbvision->palette.bytes_per_pixel;
+       vf->fmt.pix.sizeimage = vf->fmt.pix.bytesperline * usbvision->curheight;
        vf->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
        vf->fmt.pix.field = V4L2_FIELD_NONE; /* Always progressive image */
 
        return 0;
 }
 
-static int vidioc_try_fmt_vid_cap (struct file *file, void *priv,
+static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
                               struct v4l2_format *vf)
 {
        struct usb_usbvision *usbvision = video_drvdata(file);
        int format_idx;
 
        /* Find requested format in available ones */
-       for(format_idx=0;format_idx<USBVISION_SUPPORTED_PALETTES;format_idx++) {
-               if(vf->fmt.pix.pixelformat ==
+       for (format_idx = 0; format_idx < USBVISION_SUPPORTED_PALETTES; format_idx++) {
+               if (vf->fmt.pix.pixelformat ==
                   usbvision_v4l2_format[format_idx].format) {
                        usbvision->palette = usbvision_v4l2_format[format_idx];
                        break;
                }
        }
        /* robustness */
-       if(format_idx == USBVISION_SUPPORTED_PALETTES) {
+       if (format_idx == USBVISION_SUPPORTED_PALETTES)
                return -EINVAL;
-       }
        RESTRICT_TO_RANGE(vf->fmt.pix.width, MIN_FRAME_WIDTH, MAX_FRAME_WIDTH);
        RESTRICT_TO_RANGE(vf->fmt.pix.height, MIN_FRAME_HEIGHT, MAX_FRAME_HEIGHT);
 
@@ -953,13 +944,14 @@ static int vidioc_s_fmt_vid_cap(struct file *file, void *priv,
        struct usb_usbvision *usbvision = video_drvdata(file);
        int ret;
 
-       if( 0 != (ret=vidioc_try_fmt_vid_cap (file, priv, vf)) ) {
+       ret = vidioc_try_fmt_vid_cap(file, priv, vf);
+       if (ret)
                return ret;
-       }
 
        /* stop io in case it is already in progress */
-       if(usbvision->streaming == stream_on) {
-               if ((ret = usbvision_stream_interrupt(usbvision)))
+       if (usbvision->streaming == stream_on) {
+               ret = usbvision_stream_interrupt(usbvision);
+               if (ret)
                        return ret;
        }
        usbvision_frames_free(usbvision);
@@ -979,8 +971,7 @@ static ssize_t usbvision_v4l2_read(struct file *file, char __user *buf,
        struct usb_usbvision *usbvision = video_drvdata(file);
        int noblock = file->f_flags & O_NONBLOCK;
        unsigned long lock_flags;
-
-       int ret,i;
+       int ret, i;
        struct usbvision_frame *frame;
 
        PDEBUG(DBG_IO, "%s: %ld bytes, noblock=%d", __func__,
@@ -992,15 +983,15 @@ static ssize_t usbvision_v4l2_read(struct file *file, char __user *buf,
        /* This entry point is compatible with the mmap routines
           so that a user can do either VIDIOC_QBUF/VIDIOC_DQBUF
           to get frames or call read on the device. */
-       if(!usbvision->num_frames) {
+       if (!usbvision->num_frames) {
                /* First, allocate some frames to work with
                   if this has not been done with VIDIOC_REQBUF */
                usbvision_frames_free(usbvision);
                usbvision_empty_framequeues(usbvision);
-               usbvision_frames_alloc(usbvision,USBVISION_NUMFRAMES);
+               usbvision_frames_alloc(usbvision, USBVISION_NUMFRAMES);
        }
 
-       if(usbvision->streaming != stream_on) {
+       if (usbvision->streaming != stream_on) {
                /* no stream is running, make it running ! */
                usbvision->streaming = stream_on;
                call_all(usbvision, video, s_stream, 1);
@@ -1008,9 +999,9 @@ static ssize_t usbvision_v4l2_read(struct file *file, char __user *buf,
 
        /* Then, enqueue as many frames as possible
           (like a user of VIDIOC_QBUF would do) */
-       for(i=0;i<usbvision->num_frames;i++) {
+       for (i = 0; i < usbvision->num_frames; i++) {
                frame = &usbvision->frame[i];
-               if(frame->grabstate == frame_state_unused) {
+               if (frame->grabstate == frame_state_unused) {
                        /* Mark it as ready and enqueue frame */
                        frame->grabstate = frame_state_ready;
                        frame->scanstate = scan_state_scanning;
@@ -1029,7 +1020,7 @@ static ssize_t usbvision_v4l2_read(struct file *file, char __user *buf,
 
        /* Then try to steal a frame (like a VIDIOC_DQBUF would do) */
        if (list_empty(&(usbvision->outqueue))) {
-               if(noblock)
+               if (noblock)
                        return -EAGAIN;
 
                ret = wait_event_interruptible
@@ -1059,9 +1050,8 @@ static ssize_t usbvision_v4l2_read(struct file *file, char __user *buf,
        if ((count + frame->bytes_read) > (unsigned long)frame->scanlength)
                count = frame->scanlength - frame->bytes_read;
 
-       if (copy_to_user(buf, frame->data + frame->bytes_read, count)) {
+       if (copy_to_user(buf, frame->data + frame->bytes_read, count))
                return -EFAULT;
-       }
 
        frame->bytes_read += count;
        PDEBUG(DBG_IO, "%s: {copy} count used=%ld, new bytes_read=%ld",
@@ -1069,12 +1059,12 @@ static ssize_t usbvision_v4l2_read(struct file *file, char __user *buf,
               (unsigned long)count, frame->bytes_read);
 
        /* For now, forget the frame if it has not been read in one shot. */
-/*     if (frame->bytes_read >= frame->scanlength) {*/ /* All data has been read */
+/*     if (frame->bytes_read >= frame->scanlength) {*/ /* All data has been read */
                frame->bytes_read = 0;
 
                /* Mark it as available to be used again. */
                frame->grabstate = frame_state_unused;
-/*     } */
+/*     } */
 
        return count;
 }
@@ -1089,9 +1079,8 @@ static int usbvision_v4l2_mmap(struct file *file, struct vm_area_struct *vma)
 
        PDEBUG(DBG_MMAP, "mmap");
 
-       if (!USBVISION_IS_OPERATIONAL(usbvision)) {
+       if (!USBVISION_IS_OPERATIONAL(usbvision))
                return -EFAULT;
-       }
 
        if (!(vma->vm_flags & VM_WRITE) ||
            size != PAGE_ALIGN(usbvision->max_frame_size)) {
@@ -1115,7 +1104,6 @@ static int usbvision_v4l2_mmap(struct file *file, struct vm_area_struct *vma)
 
        pos = usbvision->frame[i].data;
        while (size > 0) {
-
                if (vm_insert_page(vma, start, vmalloc_to_page(pos))) {
                        PDEBUG(DBG_MMAP, "mmap: vm_insert_page failed");
                        return -EAGAIN;
@@ -1145,9 +1133,8 @@ static int usbvision_radio_open(struct file *file)
                        "%s: Someone tried to open an already opened USBVision Radio!\n",
                                __func__);
                err_code = -EBUSY;
-       }
-       else {
-               if(power_on_at_open) {
+       } else {
+               if (power_on_at_open) {
                        usbvision_reset_power_off_timer(usbvision);
                        if (usbvision->power == 0) {
                                usbvision_power_on(usbvision);
@@ -1190,12 +1177,12 @@ static int usbvision_radio_close(struct file *file)
        PDEBUG(DBG_IO, "");
 
        /* Set packet size to 0 */
-       usbvision->iface_alt=0;
+       usbvision->iface_alt = 0;
        err_code = usb_set_interface(usbvision->dev, usbvision->iface,
                                    usbvision->iface_alt);
 
        usbvision_audio_off(usbvision);
-       usbvision->radio=0;
+       usbvision->radio = 0;
        usbvision->user--;
 
        if (power_on_at_open) {
@@ -1222,7 +1209,7 @@ static const struct v4l2_file_operations usbvision_fops = {
        .read           = usbvision_v4l2_read,
        .mmap           = usbvision_v4l2_mmap,
        .unlocked_ioctl = video_ioctl2,
-/*     .poll          = video_poll, */
+/*     .poll           = video_poll, */
 };
 
 static const struct v4l2_ioctl_ops usbvision_ioctl_ops = {
@@ -1258,11 +1245,11 @@ static const struct v4l2_ioctl_ops usbvision_ioctl_ops = {
 
 static struct video_device usbvision_video_template = {
        .fops           = &usbvision_fops,
-       .ioctl_ops      = &usbvision_ioctl_ops,
+       .ioctl_ops      = &usbvision_ioctl_ops,
        .name           = "usbvision-video",
        .release        = video_device_release,
-       .tvnorms              = USBVISION_NORMS,
-       .current_norm         = V4L2_STD_PAL
+       .tvnorms        = USBVISION_NORMS,
+       .current_norm   = V4L2_STD_PAL
 };
 
 
@@ -1292,9 +1279,9 @@ static const struct v4l2_ioctl_ops usbvision_radio_ioctl_ops = {
 
 static struct video_device usbvision_radio_template = {
        .fops           = &usbvision_radio_fops,
-       .name           = "usbvision-radio",
+       .name           = "usbvision-radio",
        .release        = video_device_release,
-       .ioctl_ops      = &usbvision_radio_ioctl_ops,
+       .ioctl_ops      = &usbvision_radio_ioctl_ops,
 
        .tvnorms              = USBVISION_NORMS,
        .current_norm         = V4L2_STD_PAL
@@ -1315,9 +1302,8 @@ static struct video_device *usbvision_vdev_init(struct usb_usbvision *usbvision,
        }
 
        vdev = video_device_alloc();
-       if (NULL == vdev) {
+       if (NULL == vdev)
                return NULL;
-       }
        *vdev = *vdev_template;
        vdev->lock = &usbvision->v4l2_lock;
        vdev->v4l2_dev = &usbvision->v4l2_dev;
@@ -1333,11 +1319,10 @@ static void usbvision_unregister_video(struct usb_usbvision *usbvision)
        if (usbvision->rdev) {
                PDEBUG(DBG_PROBE, "unregister %s [v4l2]",
                       video_device_node_name(usbvision->rdev));
-               if (video_is_registered(usbvision->rdev)) {
+               if (video_is_registered(usbvision->rdev))
                        video_unregister_device(usbvision->rdev);
-               } else {
+               else
                        video_device_release(usbvision->rdev);
-               }
                usbvision->rdev = NULL;
        }
 
@@ -1345,11 +1330,10 @@ static void usbvision_unregister_video(struct usb_usbvision *usbvision)
        if (usbvision->vdev) {
                PDEBUG(DBG_PROBE, "unregister %s [v4l2]",
                       video_device_node_name(usbvision->vdev));
-               if (video_is_registered(usbvision->vdev)) {
+               if (video_is_registered(usbvision->vdev))
                        video_unregister_device(usbvision->vdev);
-               } else {
+               else
                        video_device_release(usbvision->vdev);
-               }
                usbvision->vdev = NULL;
        }
 }
@@ -1361,14 +1345,10 @@ static int __devinit usbvision_register_video(struct usb_usbvision *usbvision)
        usbvision->vdev = usbvision_vdev_init(usbvision,
                                              &usbvision_video_template,
                                              "USBVision Video");
-       if (usbvision->vdev == NULL) {
+       if (usbvision->vdev == NULL)
                goto err_exit;
-       }
-       if (video_register_device(usbvision->vdev,
-                                 VFL_TYPE_GRABBER,
-                                 video_nr)<0) {
+       if (video_register_device(usbvision->vdev, VFL_TYPE_GRABBER, video_nr) < 0)
                goto err_exit;
-       }
        printk(KERN_INFO "USBVision[%d]: registered USBVision Video device %s [v4l2]\n",
               usbvision->nr, video_device_node_name(usbvision->vdev));
 
@@ -1378,14 +1358,10 @@ static int __devinit usbvision_register_video(struct usb_usbvision *usbvision)
                usbvision->rdev = usbvision_vdev_init(usbvision,
                                                      &usbvision_radio_template,
                                                      "USBVision Radio");
-               if (usbvision->rdev == NULL) {
+               if (usbvision->rdev == NULL)
                        goto err_exit;
-               }
-               if (video_register_device(usbvision->rdev,
-                                         VFL_TYPE_RADIO,
-                                         radio_nr)<0) {
+               if (video_register_device(usbvision->rdev, VFL_TYPE_RADIO, radio_nr) < 0)
                        goto err_exit;
-               }
                printk(KERN_INFO "USBVision[%d]: registered USBVision Radio device %s [v4l2]\n",
                       usbvision->nr, video_device_node_name(usbvision->rdev));
        }
@@ -1459,9 +1435,7 @@ static void usbvision_release(struct usb_usbvision *usbvision)
        usbvision_remove_sysfs(usbvision->vdev);
        usbvision_unregister_video(usbvision);
 
-       if (usbvision->ctrl_urb) {
-               usb_free_urb(usbvision->ctrl_urb);
-       }
+       usb_free_urb(usbvision->ctrl_urb);
 
        v4l2_device_unregister(&usbvision->v4l2_dev);
        kfree(usbvision);
@@ -1520,25 +1494,24 @@ static int __devinit usbvision_probe(struct usb_interface *intf,
        const struct usb_host_interface *interface;
        struct usb_usbvision *usbvision = NULL;
        const struct usb_endpoint_descriptor *endpoint;
-       int model,i;
+       int model, i;
 
        PDEBUG(DBG_PROBE, "VID=%#04x, PID=%#04x, ifnum=%u",
                                dev->descriptor.idVendor,
                                dev->descriptor.idProduct, ifnum);
 
        model = devid->driver_info;
-       if ( (model<0) || (model>=usbvision_device_data_size) ) {
-               PDEBUG(DBG_PROBE, "model out of bounds %d",model);
+       if (model < 0 || model >= usbvision_device_data_size) {
+               PDEBUG(DBG_PROBE, "model out of bounds %d", model);
                return -ENODEV;
        }
        printk(KERN_INFO "%s: %s found\n", __func__,
                                usbvision_device_data[model].model_string);
 
-       if (usbvision_device_data[model].interface >= 0) {
+       if (usbvision_device_data[model].interface >= 0)
                interface = &dev->actconfig->interface[usbvision_device_data[model].interface]->altsetting[0];
-       } else {
+       else
                interface = &dev->actconfig->interface[ifnum]->altsetting[0];
-       }
        endpoint = &interface->endpoint[1].desc;
        if (!usb_endpoint_xfer_isoc(endpoint)) {
                dev_err(&intf->dev, "%s: interface %d. has non-ISO endpoint!\n",
@@ -1559,33 +1532,31 @@ static int __devinit usbvision_probe(struct usb_interface *intf,
                return -ENOMEM;
        }
 
-       if (dev->descriptor.bNumConfigurations > 1) {
+       if (dev->descriptor.bNumConfigurations > 1)
                usbvision->bridge_type = BRIDGE_NT1004;
-       } else if (model == DAZZLE_DVC_90_REV_1_SECAM) {
+       else if (model == DAZZLE_DVC_90_REV_1_SECAM)
                usbvision->bridge_type = BRIDGE_NT1005;
-       } else {
+       else
                usbvision->bridge_type = BRIDGE_NT1003;
-       }
        PDEBUG(DBG_PROBE, "bridge_type %d", usbvision->bridge_type);
 
        /* compute alternate max packet sizes */
        uif = dev->actconfig->interface[0];
 
-       usbvision->num_alt=uif->num_altsetting;
-       PDEBUG(DBG_PROBE, "Alternate settings: %i",usbvision->num_alt);
-       usbvision->alt_max_pkt_size = kmalloc(32*
-                                             usbvision->num_alt,GFP_KERNEL);
+       usbvision->num_alt = uif->num_altsetting;
+       PDEBUG(DBG_PROBE, "Alternate settings: %i", usbvision->num_alt);
+       usbvision->alt_max_pkt_size = kmalloc(32 * usbvision->num_alt, GFP_KERNEL);
        if (usbvision->alt_max_pkt_size == NULL) {
                dev_err(&intf->dev, "usbvision: out of memory!\n");
                return -ENOMEM;
        }
 
-       for (i = 0; i < usbvision->num_alt ; i++) {
+       for (i = 0; i < usbvision->num_alt; i++) {
                u16 tmp = le16_to_cpu(uif->altsetting[i].endpoint[1].desc.
                                      wMaxPacketSize);
                usbvision->alt_max_pkt_size[i] =
                        (tmp & 0x07ff) * (((tmp & 0x1800) >> 11) + 1);
-               PDEBUG(DBG_PROBE, "Alternate setting %i, max size= %i",i,
+               PDEBUG(DBG_PROBE, "Alternate setting %i, max size= %i", i,
                       usbvision->alt_max_pkt_size[i]);
        }
 
@@ -1593,9 +1564,8 @@ static int __devinit usbvision_probe(struct usb_interface *intf,
        usbvision->nr = usbvision_nr++;
 
        usbvision->have_tuner = usbvision_device_data[model].tuner;
-       if (usbvision->have_tuner) {
+       if (usbvision->have_tuner)
                usbvision->tuner_type = usbvision_device_data[model].tuner_type;
-       }
 
        usbvision->dev_model = model;
        usbvision->remove_pending = 0;
@@ -1689,7 +1659,7 @@ static int __init usbvision_init(void)
        PDEBUG(DBG_MMAP, "MMAP    debugging is enabled [video]");
 
        /* disable planar mode support unless compression enabled */
-       if (isoc_mode != ISOC_MODE_COMPRESS ) {
+       if (isoc_mode != ISOC_MODE_COMPRESS) {
                /* FIXME : not the right way to set supported flag */
                usbvision_v4l2_format[6].supported = 0; /* V4L2_PIX_FMT_YVU420 */
                usbvision_v4l2_format[7].supported = 0; /* V4L2_PIX_FMT_YUV422P */
@@ -1706,10 +1676,10 @@ static int __init usbvision_init(void)
 
 static void __exit usbvision_exit(void)
 {
- PDEBUG(DBG_PROBE, "");
      PDEBUG(DBG_PROBE, "");
 
- usb_deregister(&usbvision_driver);
- PDEBUG(DBG_PROBE, "success");
      usb_deregister(&usbvision_driver);
      PDEBUG(DBG_PROBE, "success");
 }
 
 module_init(usbvision_init);
index 5141159..8074787 100644 (file)
 #define MAX_USB_HEIGHT                 240  /* 288 */
 #define MAX_FRAME_HEIGHT               240  /* 288 */                  /* Streching sometimes causes crashes*/
 
-#define MAX_FRAME_SIZE                 (MAX_FRAME_WIDTH * MAX_FRAME_HEIGHT * MAX_BYTES_PER_PIXEL)
+#define MAX_FRAME_SIZE                 (MAX_FRAME_WIDTH * MAX_FRAME_HEIGHT * MAX_BYTES_PER_PIXEL)
 #define USBVISION_CLIPMASK_SIZE                (MAX_FRAME_WIDTH * MAX_FRAME_HEIGHT / 8) /* bytesize of clipmask */
 
 #define USBVISION_URB_FRAMES           32
 #define USBVISION_NUMFRAMES            3  /* Maximum number of frames an application can get */
 #define USBVISION_NUMSBUF              2 /* Dimensioning the USB S buffering */
 
-#define USBVISION_POWEROFF_TIME                3 * (HZ)                /* 3 seconds */
+#define USBVISION_POWEROFF_TIME                (3 * HZ)                /* 3 seconds */
 
 
 #define FRAMERATE_MIN  0
@@ -161,7 +161,8 @@ enum {
 };
 
 /* This macro restricts an int variable to an inclusive range */
-#define RESTRICT_TO_RANGE(v,mi,ma) { if ((v) < (mi)) (v) = (mi); else if ((v) > (ma)) (v) = (ma); }
+#define RESTRICT_TO_RANGE(v, mi, ma) \
+       { if ((v) < (mi)) (v) = (mi); else if ((v) > (ma)) (v) = (ma); }
 
 /*
  * We use macros to do YUV -> RGB conversion because this is
@@ -183,18 +184,18 @@ enum {
  * Make sure the output values are within [0..255] range.
  */
 #define LIMIT_RGB(x) (((x) < 0) ? 0 : (((x) > 255) ? 255 : (x)))
-#define YUV_TO_RGB_BY_THE_BOOK(my,mu,mv,mr,mg,mb) { \
-    int mm_y, mm_yc, mm_u, mm_v, mm_r, mm_g, mm_b; \
-    mm_y = (my) - 16;  \
-    mm_u = (mu) - 128; \
-    mm_v = (mv) - 128; \
-    mm_yc= mm_y * 76284; \
-    mm_b = (mm_yc              + 132252*mm_v   ) >> 16; \
-    mm_g = (mm_yc -  53281*mm_u -  25625*mm_v  ) >> 16; \
-    mm_r = (mm_yc + 104595*mm_u                        ) >> 16; \
-    mb = LIMIT_RGB(mm_b); \
-    mg = LIMIT_RGB(mm_g); \
-    mr = LIMIT_RGB(mm_r); \
+#define YUV_TO_RGB_BY_THE_BOOK(my, mu, mv, mr, mg, mb) { \
+       int mm_y, mm_yc, mm_u, mm_v, mm_r, mm_g, mm_b; \
+       mm_y = (my) - 16; \
+       mm_u = (mu) - 128; \
+       mm_v = (mv) - 128; \
+       mm_yc = mm_y * 76284; \
+       mm_b = (mm_yc + 132252 * mm_v) >> 16; \
+       mm_g = (mm_yc - 53281 * mm_u - 25625 * mm_v) >> 16; \
+       mm_r = (mm_yc + 104595 * mm_u) >> 16; \
+       mb = LIMIT_RGB(mm_b); \
+       mg = LIMIT_RGB(mm_g); \
+       mr = LIMIT_RGB(mm_r); \
 }
 
 /* Debugging aid */
@@ -202,7 +203,7 @@ enum {
        wait_queue_head_t wq; \
        init_waitqueue_head(&wq); \
        printk(KERN_INFO "Say: %s\n", what); \
-       interruptible_sleep_on_timeout (&wq, HZ*3); \
+       interruptible_sleep_on_timeout(&wq, HZ * 3); \
 }
 
 /*
@@ -265,8 +266,8 @@ struct usbvision_sbuf {
        struct urb *urb;
 };
 
-#define USBVISION_MAGIC_1                              0x55
-#define USBVISION_MAGIC_2                              0xAA
+#define USBVISION_MAGIC_1                      0x55
+#define USBVISION_MAGIC_2                      0xAA
 #define USBVISION_HEADER_LENGTH                        0x0c
 #define USBVISION_SAA7111_ADDR                 0x48
 #define USBVISION_SAA7113_ADDR                 0x4a
@@ -358,8 +359,8 @@ extern struct usb_device_id usbvision_table[];
 
 struct usb_usbvision {
        struct v4l2_device v4l2_dev;
-       struct video_device *vdev;                                      /* Video Device */
-       struct video_device *rdev;                                      /* Radio Device */
+       struct video_device *vdev;                                      /* Video Device */
+       struct video_device *rdev;                                      /* Radio Device */
 
        /* i2c Declaration Section*/
        struct i2c_adapter i2c_adap;
@@ -401,7 +402,7 @@ struct usb_usbvision {
        enum stream_state streaming;                                    /* Are we streaming Isochronous? */
        int last_error;                                                 /* What calamity struck us? */
        int curwidth;                                                   /* width of the frame the device is currently set to*/
-       int curheight;                                                  /* height of the frame the device is currently set to*/
+       int curheight;                                                  /* height of the frame the device is currently set to*/
        int stretch_width;                                              /* stretch-factor for frame width (from usb to screen)*/
        int stretch_height;                                             /* stretch-factor for frame height (from usb to screen)*/
        char *fbuf;                                                     /* Videodev buffer area for mmap*/
@@ -434,7 +435,7 @@ struct usb_usbvision {
 
        /* Decompression stuff: */
        unsigned char *intra_frame_buffer;                              /* Buffer for reference frame */
-       int block_pos;                                                  /* for test only */
+       int block_pos;                                                  /* for test only */
        int request_intra;                                              /* 0 = normal; 1 = intra frame is requested; */
        int last_isoc_frame_num;                                        /* check for lost isoc frames */
        int isoc_packet_size;                                           /* need to calculate used_bandwidth */
@@ -494,7 +495,7 @@ void usbvision_scratch_free(struct usb_usbvision *usbvision);
 int usbvision_decompress_alloc(struct usb_usbvision *usbvision);
 void usbvision_decompress_free(struct usb_usbvision *usbvision);
 
-int usbvision_setup(struct usb_usbvision *usbvision,int format);
+int usbvision_setup(struct usb_usbvision *usbvision, int format);
 int usbvision_init_isoc(struct usb_usbvision *usbvision);
 int usbvision_restart_isoc(struct usb_usbvision *usbvision);
 void usbvision_stop_isoc(struct usb_usbvision *usbvision);