hwrng: omap - add missing clk_put
authorJulia Lawall <julia@diku.dk>
Wed, 8 Jun 2011 12:59:38 +0000 (20:59 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 29 Jun 2011 23:44:01 +0000 (07:44 +0800)
Convert a return to a jump to an existing label that calls clk_put.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression e1,e2;
statement S;
@@

e1 = clk_get@p1(...);
... when != e1 = e2
    when != clk_put(e1)
    when any
if (...) { ... when != clk_put(e1)
               when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
 } else S
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/omap-rng.c

index 2cc755a..b757fac 100644 (file)
@@ -113,8 +113,10 @@ static int __devinit omap_rng_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 
-       if (!res)
-               return -ENOENT;
+       if (!res) {
+               ret = -ENOENT;
+               goto err_region;
+       }
 
        if (!request_mem_region(res->start, resource_size(res), pdev->name)) {
                ret = -EBUSY;