[media] siano: unnecessary check before rc_unregister_device()
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 24 Nov 2014 21:32:30 +0000 (18:32 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 25 Nov 2014 15:44:34 +0000 (13:44 -0200)
The rc_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/common/siano/smsir.c

index 273043e..35d0e88 100644 (file)
@@ -107,8 +107,7 @@ int sms_ir_init(struct smscore_device_t *coredev)
 
 void sms_ir_exit(struct smscore_device_t *coredev)
 {
-       if (coredev->ir.dev)
-               rc_unregister_device(coredev->ir.dev);
+       rc_unregister_device(coredev->ir.dev);
 
        sms_log("");
 }