i82875p_edac: Drop redundant call to pci_get_device()
authorJean Delvare <jdelvare@suse.de>
Mon, 24 Feb 2014 15:03:16 +0000 (16:03 +0100)
committerBorislav Petkov <bp@suse.de>
Tue, 25 Feb 2014 09:13:46 +0000 (10:13 +0100)
The first call to pci_get_device() in i82875p_probe1() is useless. The
result is immediately reset at the beginning of
i82875p_setup_overfl_dev(), which then issues the same
pci_get_device() call. Dropping the redundant call avoids a device
reference leak.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Link: http://lkml.kernel.org/r/20140224160316.60e55fb6@endymion.delvare
Cc: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/i82875p_edac.c

index 80573df..8d0450b 100644 (file)
@@ -406,8 +406,6 @@ static int i82875p_probe1(struct pci_dev *pdev, int dev_idx)
 
        edac_dbg(0, "\n");
 
-       ovrfl_pdev = pci_get_device(PCI_VEND_DEV(INTEL, 82875_6), NULL);
-
        if (i82875p_setup_overfl_dev(pdev, &ovrfl_pdev, &ovrfl_window))
                return -ENODEV;
        drc = readl(ovrfl_window + I82875P_DRC);