usb: gadget: tcm_usb_gadge: fix to return error or 0 in tcm_usbg_drop_nexus()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Wed, 14 Nov 2012 05:47:23 +0000 (13:47 +0800)
committerFelipe Balbi <balbi@ti.com>
Thu, 13 Dec 2012 10:04:00 +0000 (12:04 +0200)
In the error handling case of tcm_usbg_drop_nexus(), the error code
is assigned to 'ret', but it is ignored. We'd better return 'ret'
instead of always return 0.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/tcm_usb_gadget.c

index 4f7f76f..7cacd6a 100644 (file)
@@ -1794,9 +1794,10 @@ static int tcm_usbg_drop_nexus(struct usbg_tpg *tpg)
        tpg->tpg_nexus = NULL;
 
        kfree(tv_nexus);
+       ret = 0;
 out:
        mutex_unlock(&tpg->tpg_mutex);
-       return 0;
+       return ret;
 }
 
 static ssize_t tcm_usbg_tpg_store_nexus(