ASoC: wm0010: Add missing IRQF_ONESHOT
authorFengguang Wu <fengguang.wu@intel.com>
Thu, 30 Aug 2012 15:16:52 +0000 (08:16 -0700)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 5 Sep 2012 22:20:02 +0000 (06:20 +0800)
FYI, there are new coccinelle warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7
head:   e3523e01869da20fdd12ffd19ae1df7bf492650e
commit: e3523e01869da20fdd12ffd19ae1df7bf492650e [95/95] ASoC: wm0010: Add initial wm0010 DSP driver

All coccinelle warnings:

+ sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
--
+ sound/soc/codecs/wm0010.c:660:1-7: preceding lock on line 359

vim +850 sound/soc/codecs/wm0010.c
   847 trigger = IRQF_TRIGGER_FALLING;
   848 trigger |= IRQF_ONESHOT;
   849
 > 850 ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger,
   851    "wm0010", wm0010);
   852 if (ret)
   853 dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",

Please consider folding the attached diff :-)

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/codecs/wm0010.c

index 5f99148..a4c3511 100644 (file)
@@ -881,7 +881,7 @@ static int __devinit wm0010_spi_probe(struct spi_device *spi)
                trigger = IRQF_TRIGGER_FALLING;
        trigger |= IRQF_ONESHOT;
 
-       ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger,
+       ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger | IRQF_ONESHOT,
                                   "wm0010", wm0010);
        if (ret) {
                dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",