usb: renesas_usbhs: tidyup for smatch warnings
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 18 Oct 2011 01:04:37 +0000 (18:04 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 18 Oct 2011 20:51:34 +0000 (13:51 -0700)
This patch tidyup below smatch complaint

drivers/usb/renesas_usbhs/mod_host.c +447 usbhsh_endpoint_free()
 warn: variable dereferenced before check 'uep' (see line 444)

Special thanks to Dan

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/renesas_usbhs/mod_host.c

index 1c60331..1a7208a 100644 (file)
@@ -441,14 +441,13 @@ void usbhsh_endpoint_free(struct usbhsh_hpriv *hpriv,
        struct usbhs_priv *priv = usbhsh_hpriv_to_priv(hpriv);
        struct device *dev = usbhs_priv_to_dev(priv);
        struct usbhsh_ep *uep = usbhsh_ep_to_uep(ep);
-       struct usbhsh_device *udev = usbhsh_uep_to_udev(uep);
        struct usbhsh_pipe_info *info;
 
        if (!uep)
                return;
 
        dev_dbg(dev, "%s [%d-%s](%p)\n", __func__,
-               usbhsh_device_number(hpriv, udev),
+               usbhsh_device_number(hpriv, usbhsh_uep_to_udev(uep)),
                usbhs_pipe_name(uep->pipe), uep);
 
        info = usbhsh_pipe_info(uep->pipe);