V4L/DVB (11648): gspca - m5602: Remove some needless error checking and add comments
authorErik Andrén <erik.andren@gmail.com>
Wed, 28 Jan 2009 07:02:49 +0000 (04:02 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 16 Jun 2009 21:20:49 +0000 (18:20 -0300)
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/gspca/m5602/m5602_core.c

index ca77dab..8ca5643 100644 (file)
@@ -112,18 +112,16 @@ int m5602_read_sensor(struct sd *sd, const u8 address,
        if (err < 0)
                return err;
 
+       /* Sensors with registers that only are one byte width are differently read */
+       /* FIXME: This works with the ov9650, but has issues with the po1030 */
        if (sd->sensor->i2c_regW == 1) {
-               err = m5602_write_bridge(sd, M5602_XB_I2C_CTRL, len);
+               err = m5602_write_bridge(sd, M5602_XB_I2C_CTRL, 1);
                if (err < 0)
                        return err;
 
                err = m5602_write_bridge(sd, M5602_XB_I2C_CTRL, 0x08);
-               if (err < 0)
-                       return err;
        } else {
                err = m5602_write_bridge(sd, M5602_XB_I2C_CTRL, 0x18 + len);
-               if (err < 0)
-                       return err;
        }
 
        for (i = 0; (i < len) && !err; i++) {