wimax/i2400m: correct the error path handlers in dev_start()
authorCindy H Kao <cindy.h.kao@intel.com>
Wed, 31 Mar 2010 02:19:37 +0000 (19:19 -0700)
committerInaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Tue, 11 May 2010 21:04:54 +0000 (14:04 -0700)
This fix is to correct order of the handlers in the error path
of dev_start(). When i2400m_firmware_check fails, all the works done
before it should be released or cleared.

Signed-off-by: Cindy H Kao <cindy.h.kao@intel.com>
drivers/net/wimax/i2400m/driver.c

index 94dc83c..3a6c8dd 100644 (file)
@@ -403,10 +403,10 @@ retry:
 
 error_dev_initialize:
 error_check_mac_addr:
+error_fw_check:
        i2400m->ready = 0;
        wmb();          /* see i2400m->ready's documentation  */
        flush_workqueue(i2400m->work_queue);
-error_fw_check:
        if (i2400m->bus_dev_stop)
                i2400m->bus_dev_stop(i2400m);
 error_bus_dev_start: