tty-hvsi_lib: Deletion of an unnecessary check before the function call "tty_kref_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 21 Nov 2014 11:40:32 +0000 (12:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Nov 2014 03:35:49 +0000 (19:35 -0800)
The tty_kref_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/hvc/hvsi_lib.c

index 7ae6c29..a270f04 100644 (file)
@@ -405,8 +405,7 @@ void hvsilib_close(struct hvsi_priv *pv, struct hvc_struct *hp)
                hvsi_send_close(pv);
        }
 
-       if (pv->tty)
-               tty_kref_put(pv->tty);
+       tty_kref_put(pv->tty);
        pv->tty = NULL;
 }