staging: comedi: amplc_pc236: remove dev_err() message due to allocation failure
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 3 Feb 2014 17:43:26 +0000 (10:43 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Feb 2014 18:49:19 +0000 (10:49 -0800)
The subdev_8255_init() call can only fail due to the allocation of the private
data. This failure will alreay have produced an error message. Remove the
redundant dev_err().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/amplc_pc236.c

index 31734e1..12eabd6 100644 (file)
@@ -411,10 +411,9 @@ static int pc236_common_attach(struct comedi_device *dev, unsigned long iobase,
        s = &dev->subdevices[0];
        /* digital i/o subdevice (8255) */
        ret = subdev_8255_init(dev, s, NULL, iobase);
-       if (ret < 0) {
-               dev_err(dev->class_dev, "error! out of memory!\n");
+       if (ret)
                return ret;
-       }
+
        s = &dev->subdevices[1];
        dev->read_subdev = s;
        s->type = COMEDI_SUBD_UNUSED;