cpufreq: tegra: update comment for clarity
authorViresh Kumar <viresh.kumar@linaro.org>
Tue, 10 Jun 2014 04:57:12 +0000 (10:27 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 10 Jun 2014 20:50:50 +0000 (22:50 +0200)
Tegra's driver got updated a bit (00917dd cpufreq: Tegra: implement intermediate
frequency callbacks) and implements new 'intermediate freq' infrastructure of
core. Above commit updated comments about when to call
clk_prepare_enable(pll_x_clk) and Doug wasn't satisfied with those comments and
said this:

> The "Though when target-freq is intermediate freq, we don't need to
> take this reference." makes me think that this function is actually
> called when target-freq is intermediate freq.  I don't think it is,
> right?

For better clarity just make that comment more explicit about when we call
tegra_target_intermediate().

Reviewed-by: Stephen Warren <swarren@nvidia.com>
Reported-and-reviewed-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/tegra-cpufreq.c

index a5fbc0a..8084c7f 100644 (file)
@@ -71,9 +71,12 @@ static int tegra_target_intermediate(struct cpufreq_policy *policy,
        /*
         * Take an extra reference to the main pll so it doesn't turn
         * off when we move the cpu off of it as enabling it again while we
-        * switch to it from tegra_target() would take additional time. Though
-        * when target-freq is intermediate freq, we don't need to take this
-        * reference.
+        * switch to it from tegra_target() would take additional time.
+        *
+        * When target-freq is equal to intermediate freq we don't need to
+        * switch to an intermediate freq and so this routine isn't called.
+        * Also, we wouldn't be using pll_x anymore and must not take extra
+        * reference to it, as it can be disabled now to save some power.
         */
        clk_prepare_enable(pll_x_clk);