pinctrl: imx: Fix compilation with DEBUG enabled
authorSascha Hauer <s.hauer@pengutronix.de>
Fri, 23 Aug 2013 08:38:57 +0000 (10:38 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 23 Aug 2013 18:52:46 +0000 (20:52 +0200)
This became broken with converting the pinmux arrays into struct
types. While at it replace the preprocessor magic with a simple
dev_dbg.

Reported-by: Tushar Behera <tushar.behera@linaro.org>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-imx.c

index 3a14245..3602493 100644 (file)
 #include "core.h"
 #include "pinctrl-imx.h"
 
-#define IMX_PMX_DUMP(info, p, m, c, n)                 \
-{                                                      \
-       int i, j;                                       \
-       printk(KERN_DEBUG "Format: Pin Mux Config\n");  \
-       for (i = 0; i < n; i++) {                       \
-               j = p[i];                               \
-               printk(KERN_DEBUG "%s %d 0x%lx\n",      \
-                       info->pins[j].name,             \
-                       m[i], c[i]);                    \
-       }                                               \
-}
-
 /* The bits in CONFIG cell defined in binding doc*/
 #define IMX_NO_PAD_CTL 0x80000000      /* no pin config need */
 #define IMX_PAD_SION 0x40000000                /* set SION */
@@ -498,11 +486,10 @@ static int imx_pinctrl_parse_groups(struct device_node *np,
                if (config & IMX_PAD_SION)
                        pin->mux_mode |= IOMUXC_CONFIG_SION;
                pin->config = config & ~IMX_PAD_SION;
-       }
 
-#ifdef DEBUG
-       IMX_PMX_DUMP(info, grp->pins, grp->mux_mode, grp->configs, grp->npins);
-#endif
+               dev_dbg(info->dev, "%s: %d 0x%08lx", info->pins[i].name,
+                               pin->mux_mode, pin->config);
+       }
 
        return 0;
 }