x86, ioapic: Print out irte with right ioapic index
authorYinghai Lu <yinghai.lu@oracle.com>
Wed, 12 Oct 2011 07:33:28 +0000 (00:33 -0700)
committerIngo Molnar <mingo@elte.hu>
Wed, 12 Oct 2011 07:55:21 +0000 (09:55 +0200)
While checking irte dump in dmesg, the print out is confusing
ioapic index with real io apic id:

IOAPIC[0]: Set routing entry (1-1 -> 0x31 -> IRQ 1 Mode:0
Active:0 Dest:1) IOAPIC[1]: Set IRTE entry (P:1 FPD:0 Dst_Mode:1
Redir_hint:1 Trig_Mode:0 Dlvry_Mode:1 Avail:0 Vector:31
Dest:00000001 SID:00FF SQ:0 SVT:1) IOAPIC[0]: Set routing entry
(1-2 -> 0x30 -> IRQ 0 Mode:0 Active:0 Dest:1) IOAPIC[1]: Set IRTE entry (P:1 FPD:0 Dst_Mode:1 Redir_hint:1 Trig_Mode:0 Dlvry_Mode:1 Avail:0 Vector:30 Dest:00000001 SID:00FF SQ:0 SVT:1)

The system's first ioapic id is 1.

This commit:

| commit 3040db92ee1b6c5b6b6d73f8cdcad54c0da11563
| Author: Naga Chumbalkar <nagananda.chumbalkar@hp.com>
| Date:   Tue Jul 12 21:17:41 2011 +0000
|
|    x86, ioapic: Print IRTE when IR is enabled

Confused apic_id with the ioapic ID - fix it.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Naga Chumbalkar <nagananda.chumbalkar@hp.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Link: http://lkml.kernel.org/r/4E9542C8.8040209@oracle.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/apic/io_apic.c

index 2fbb9d6..a781506 100644 (file)
@@ -1289,7 +1289,7 @@ static int setup_ir_ioapic_entry(int irq,
                "Redir_hint:%d Trig_Mode:%d Dlvry_Mode:%X "
                "Avail:%X Vector:%02X Dest:%08X "
                "SID:%04X SQ:%X SVT:%X)\n",
-               apic_id, irte.present, irte.fpd, irte.dst_mode,
+               attr->ioapic, irte.present, irte.fpd, irte.dst_mode,
                irte.redir_hint, irte.trigger_mode, irte.dlvry_mode,
                irte.avail, irte.vector, irte.dest_id,
                irte.sid, irte.sq, irte.svt);