OMAPDSS: DSI: use c99 initializers in structures
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 23 Aug 2014 11:20:29 +0000 (13:20 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 26 Aug 2014 12:52:39 +0000 (15:52 +0300)
Use c99 initializers for structures.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@decl@
identifier i1,fld;
type T;
field list[n] fs;
@@

struct i1 {
 fs
 T fld;
 ...};

@bad@
identifier decl.i1,i2;
expression e;
initializer list[decl.n] is;
@@

struct i1 i2 = { is,
+ .fld = e
- e
 ,...};
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/omap2/dss/dsi.c

index 56b9244..b6f6ae1 100644 (file)
@@ -2571,7 +2571,10 @@ static int dsi_sync_vc_vp(struct platform_device *dsidev, int channel)
 {
        struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
        DECLARE_COMPLETION_ONSTACK(completion);
-       struct dsi_packet_sent_handler_data vp_data = { dsidev, &completion };
+       struct dsi_packet_sent_handler_data vp_data = {
+               .dsidev = dsidev,
+               .completion = &completion
+       };
        int r = 0;
        u8 bit;
 
@@ -2617,7 +2620,10 @@ static void dsi_packet_sent_handler_l4(void *data, u32 mask)
 static int dsi_sync_vc_l4(struct platform_device *dsidev, int channel)
 {
        DECLARE_COMPLETION_ONSTACK(completion);
-       struct dsi_packet_sent_handler_data l4_data = { dsidev, &completion };
+       struct dsi_packet_sent_handler_data l4_data = {
+               .dsidev = dsidev,
+               .completion = &completion
+       };
        int r = 0;
 
        r = dsi_register_isr_vc(dsidev, channel, dsi_packet_sent_handler_l4,