drivers/leds/leds-lp5521.c: ret may be uninitialized
authorSrinidhi KASAGAR <srinidhi.kasagar@stericsson.com>
Fri, 23 Mar 2012 22:02:09 +0000 (15:02 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 3 Jan 2013 03:32:50 +0000 (03:32 +0000)
commit 42960b76d2c6a44d7e8000f4eb9a4ca1780059ff upstream.

Fix it by assigning the lp5521_read return value.

Signed-off-by: srinidhi kasagar <srinidhi.kasagar@stericsson.com>
Cc: Milo(Woogyom) Kim <milo.kim@ti.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Arun MURTHY <arun.murthy@stericsson.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/leds/leds-lp5521.c

index e47902c..47771ad 100644 (file)
@@ -692,7 +692,7 @@ static int __devinit lp5521_probe(struct i2c_client *client,
         * otherwise further access to the R G B channels in the
         * LP5521_REG_ENABLE register will not have any effect - strange!
         */
-       lp5521_read(client, LP5521_REG_R_CURRENT, &buf);
+       ret = lp5521_read(client, LP5521_REG_R_CURRENT, &buf);
        if (buf != LP5521_REG_R_CURR_DEFAULT) {
                dev_err(&client->dev, "error in resetting chip\n");
                goto fail2;