usb: gadget: dummy: do not call pullup() on udc_stop()
authorFelipe Balbi <balbi@ti.com>
Wed, 18 Apr 2012 10:59:30 +0000 (13:59 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 May 2012 12:14:42 +0000 (13:14 +0100)
commit 15b120d67019d691e4389372967332d74a80522a upstream.

pullup() is already called properly by udc-core.c and
there's no need to call it from udc_stop(), in fact that
will cause issues.

Reviewed-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/gadget/dummy_hcd.c

index ab8f1b4..527736e 100644 (file)
@@ -925,7 +925,6 @@ static int dummy_udc_stop(struct usb_gadget *g,
 
        dum->driver = NULL;
 
-       dummy_pullup(&dum->gadget, 0);
        return 0;
 }