git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f7a1dd6
)
net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W
author
Chen Gang
<gang.chen@asianux.com>
Thu, 25 Apr 2013 00:49:55 +0000
(
00:49
+0000)
committer
David S. Miller
<davem@davemloft.net>
Mon, 29 Apr 2013 16:29:04 +0000
(12:29 -0400)
Change MAC802154_CHAN_NONE from ~(u8)0 to 0xff, or the comparison in
mac802154_wpan_xmit() for ``chan == MAC802154_CHAN_NONE'' will not
succeed.
This bug can be boiled down to ``u8 foo = 0xff; if (foo == ~(u8)0)
[...] else [...]'' where the condition will always take the else
branch.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mac802154/mac802154.h
patch
|
blob
|
history
diff --cc
net/mac802154/mac802154.h
Simple merge