Make ISDN CAPI use seq_list_xxx helpers
authorPavel Emelianov <xemul@sw.ru>
Tue, 17 Jul 2007 11:04:18 +0000 (04:04 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 17 Jul 2007 17:23:05 +0000 (10:23 -0700)
The similar code exists here and is called capi_driver_get_idx().  Use generic
helpers now and remember to convert list_head to struct capi_driver in .show
callback.

Signed-off-by: Pavel Emelianov <xemul@openvz.org>
Acked-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/isdn/capi/kcapi_proc.c

index 31f4fd8..845a797 100644 (file)
@@ -243,36 +243,15 @@ create_seq_entry(char *name, mode_t mode, const struct file_operations *f)
 
 // ---------------------------------------------------------------------------
 
-
-static __inline__ struct capi_driver *capi_driver_get_idx(loff_t pos)
-{
-       struct capi_driver *drv = NULL;
-       struct list_head *l;
-       loff_t i;
-
-       i = 0;
-       list_for_each(l, &capi_drivers) {
-               drv = list_entry(l, struct capi_driver, list);
-               if (i++ == pos)
-                       return drv;
-       }
-       return NULL;
-}
-
 static void *capi_driver_start(struct seq_file *seq, loff_t *pos)
 {
-       struct capi_driver *drv;
        read_lock(&capi_drivers_list_lock);
-       drv = capi_driver_get_idx(*pos);
-       return drv;
+       return seq_list_start(&capi_drivers, *pos);
 }
 
 static void *capi_driver_next(struct seq_file *seq, void *v, loff_t *pos)
 {
-       struct capi_driver *drv = (struct capi_driver *)v;
-       ++*pos;
-       if (drv->list.next == &capi_drivers) return NULL;
-       return list_entry(drv->list.next, struct capi_driver, list);
+       return seq_list_next(v, &capi_drivers, pos);
 }
 
 static void capi_driver_stop(struct seq_file *seq, void *v)
@@ -282,7 +261,8 @@ static void capi_driver_stop(struct seq_file *seq, void *v)
 
 static int capi_driver_show(struct seq_file *seq, void *v)
 {
-       struct capi_driver *drv = (struct capi_driver *)v;
+       struct capi_driver *drv = list_entry(v, struct capi_driver, list);
+
        seq_printf(seq, "%-32s %s\n", drv->name, drv->revision);
        return 0;
 }