]> git.openpandora.org Git - pandora-kernel.git/commitdiff
drm/i915: Make ->update_primary_plane infallible
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 24 Apr 2014 21:55:01 +0000 (23:55 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 19 May 2014 13:31:04 +0000 (15:31 +0200)
Way back we've used this to reject framebuffers with unsupported
pixel formats. But since the modesetting reorg with the compute
config stage we reject those much earlier and just BUG() in this
callback. So switch to a void return type.

Reviewed-by: Akash Goel <akash.goel@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/intel_display.c

index a270e0773e2dcd1a3b415bad728c7bfd434edcd1..c0fd2c14d1c053af5715aed50bd30e6119672908 100644 (file)
@@ -471,9 +471,9 @@ struct drm_i915_display_funcs {
                          struct drm_framebuffer *fb,
                          struct drm_i915_gem_object *obj,
                          uint32_t flags);
-       int (*update_primary_plane)(struct drm_crtc *crtc,
-                                   struct drm_framebuffer *fb,
-                                   int x, int y);
+       void (*update_primary_plane)(struct drm_crtc *crtc,
+                                    struct drm_framebuffer *fb,
+                                    int x, int y);
        void (*hpd_irq_setup)(struct drm_device *dev);
        /* clock updates for mode set */
        /* cursor updates */
Simple merge