ASoC: rsnd: route setting is needed only Gen1
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 20 Dec 2013 03:27:37 +0000 (19:27 -0800)
committerMark Brown <broonie@linaro.org>
Tue, 31 Dec 2013 13:35:30 +0000 (13:35 +0000)
Renesas sound has SRC (= Sampling Rate Converter),
but, the HW implementation depends on its generation.
It was part of SRU on Gen1, and SCU on Gen2.
This SCU needs DMA transfer to use it.
Current rsnd driver is using it as DMA transfer buffer
(= no rate convert), and Gen1 is only supported at this point.

This patch cleanup it with focusing about SRC and Gen2 part.

rsnd_scu_set_route() is needed only Gen1.

This patch renames it to rsnd_scu_set_route_if_gen1()
and it adds comment to rsnd_reg member
in order to clarify it is used for Gen1.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/sh/rcar/rsnd.h
sound/soc/sh/rcar/scu.c

index d5c0182..a14bc92 100644 (file)
  */
 enum rsnd_reg {
        /* SRU/SCU/SSIU */
-       RSND_REG_SRC_ROUTE_SEL,
-       RSND_REG_SRC_TMG_SEL0,
-       RSND_REG_SRC_TMG_SEL1,
-       RSND_REG_SRC_TMG_SEL2,
-       RSND_REG_SRC_ROUTE_CTRL,
+       RSND_REG_SRC_ROUTE_SEL,         /* for Gen1 */
+       RSND_REG_SRC_TMG_SEL0,          /* for Gen1 */
+       RSND_REG_SRC_TMG_SEL1,          /* for Gen1 */
+       RSND_REG_SRC_TMG_SEL2,          /* for Gen1 */
+       RSND_REG_SRC_ROUTE_CTRL,        /* for Gen1 */
        RSND_REG_SSI_MODE0,
        RSND_REG_SSI_MODE1,
        RSND_REG_BUSIF_MODE,
index 187f7dc..7642ec5 100644 (file)
@@ -36,7 +36,8 @@ struct rsnd_scu {
                     ((pos) = (struct rsnd_scu *)(priv)->scu + i);      \
             i++)
 
-static int rsnd_scu_set_route(struct rsnd_priv *priv,
+/* Gen1 only */
+static int rsnd_src_set_route_if_gen1(struct rsnd_priv *priv,
                              struct rsnd_mod *mod,
                              struct rsnd_dai *rdai,
                              struct rsnd_dai_stream *io)
@@ -174,7 +175,8 @@ static int rsnd_scu_start(struct rsnd_mod *mod,
        }
 
        /* it use DMA transter */
-       ret = rsnd_scu_set_route(priv, mod, rdai, io);
+
+       ret = rsnd_src_set_route_if_gen1(priv, mod, rdai, io);
        if (ret < 0)
                return ret;