percpu: fix locking regression in the failure path of pcpu_alloc()
authorTejun Heo <tj@kernel.org>
Mon, 8 Sep 2014 23:02:45 +0000 (08:02 +0900)
committerTejun Heo <tj@kernel.org>
Mon, 8 Sep 2014 23:02:45 +0000 (08:02 +0900)
While updating locking, b38d08f3181c ("percpu: restructure locking")
broke pcpu_create_chunk() creation path in pcpu_alloc().  It returns
without releasing pcpu_alloc_mutex.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
mm/percpu.c

index 867efd3..af3dd27 100644 (file)
@@ -974,6 +974,7 @@ restart:
        if (list_empty(&pcpu_slot[pcpu_nr_slots - 1])) {
                chunk = pcpu_create_chunk();
                if (!chunk) {
+                       mutex_unlock(&pcpu_alloc_mutex);
                        err = "failed to allocate new chunk";
                        goto fail;
                }