pinctrl: msm: drop negativity check on unsigned value
authorAndrey Utkin <andrey.krieger.utkin@gmail.com>
Thu, 17 Jul 2014 16:29:39 +0000 (19:29 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 23 Jul 2014 13:24:40 +0000 (15:24 +0200)
[linux-3.16-rc5/drivers/pinctrl/pinctrl-msm.c:145]: (style) Checking if
unsigned variable 'mux_bit' is less than zero.

    if (WARN_ON(g->mux_bit < 0))
        return -EINVAL;

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80491
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-msm.c

index 90d383d..2738108 100644 (file)
@@ -142,9 +142,6 @@ static int msm_pinmux_enable(struct pinctrl_dev *pctldev,
 
        g = &pctrl->soc->groups[group];
 
-       if (WARN_ON(g->mux_bit < 0))
-               return -EINVAL;
-
        for (i = 0; i < g->nfuncs; i++) {
                if (g->funcs[i] == function)
                        break;