block: let blk_end_request_all handle bidi requests
authorFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Mon, 11 May 2009 08:56:07 +0000 (17:56 +0900)
committerJens Axboe <jens.axboe@oracle.com>
Mon, 11 May 2009 09:06:47 +0000 (11:06 +0200)
blk_end_request_all() and __blk_end_request_all() should finish all
bytes including bidi, by definition. That's what all bidi users need ,
bidi requests must be complete as a whole (partial completion is
impossible).

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
include/linux/blkdev.h

index 6e59d3b..1069f44 100644 (file)
@@ -910,8 +910,12 @@ static inline bool blk_end_request(struct request *rq, int error,
 static inline void blk_end_request_all(struct request *rq, int error)
 {
        bool pending;
+       unsigned int bidi_bytes = 0;
 
-       pending = blk_end_request(rq, error, blk_rq_bytes(rq));
+       if (unlikely(blk_bidi_rq(rq)))
+               bidi_bytes = blk_rq_bytes(rq->next_rq);
+
+       pending = blk_end_bidi_request(rq, error, blk_rq_bytes(rq), bidi_bytes);
        BUG_ON(pending);
 }
 
@@ -962,8 +966,12 @@ static inline bool __blk_end_request(struct request *rq, int error,
 static inline void __blk_end_request_all(struct request *rq, int error)
 {
        bool pending;
+       unsigned int bidi_bytes = 0;
+
+       if (unlikely(blk_bidi_rq(rq)))
+               bidi_bytes = blk_rq_bytes(rq->next_rq);
 
-       pending = __blk_end_request(rq, error, blk_rq_bytes(rq));
+       pending = __blk_end_bidi_request(rq, error, blk_rq_bytes(rq), bidi_bytes);
        BUG_ON(pending);
 }