video: udlfb: Deletion of unnecessary checks before the function call "vfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 23 Nov 2014 10:40:47 +0000 (11:40 +0100)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 4 Dec 2014 14:16:01 +0000 (16:16 +0200)
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/udlfb.c

index 046d51d..ff2b873 100644 (file)
@@ -922,8 +922,7 @@ static void dlfb_free(struct kref *kref)
 {
        struct dlfb_data *dev = container_of(kref, struct dlfb_data, kref);
 
-       if (dev->backing_buffer)
-               vfree(dev->backing_buffer);
+       vfree(dev->backing_buffer);
 
        kfree(dev->edid);
 
@@ -953,8 +952,7 @@ static void dlfb_free_framebuffer(struct dlfb_data *dev)
                        fb_dealloc_cmap(&info->cmap);
                if (info->monspecs.modedb)
                        fb_destroy_modedb(info->monspecs.modedb);
-               if (info->screen_base)
-                       vfree(info->screen_base);
+               vfree(info->screen_base);
 
                fb_destroy_modelist(&info->modelist);
 
@@ -1203,8 +1201,7 @@ static int dlfb_realloc_framebuffer(struct dlfb_data *dev, struct fb_info *info)
                if (!new_back)
                        pr_info("No shadow/backing buffer allocated\n");
                else {
-                       if (dev->backing_buffer)
-                               vfree(dev->backing_buffer);
+                       vfree(dev->backing_buffer);
                        dev->backing_buffer = new_back;
                }
        }