[SCSI] bfa: vport state machine fix
authorJing Huang <huangj@brocade.com>
Fri, 9 Jul 2010 02:47:08 +0000 (19:47 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Tue, 27 Jul 2010 17:04:05 +0000 (12:04 -0500)
Vport state machine does not cleanup associated lport in some states: while
waiting for fdisc response or fdisc failure state. The fixe is to cleanup lport
on vport delete in all states.  In fdisc state, discard fdisc response and
delete lport and wait for lport deletecompletion. in error state, delete lport
and wait for delete completion.

Signed-off-by: Jing Huang <huangj@brocade.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/bfa/vport.c

index f14e9f2..66f30a0 100644 (file)
@@ -218,9 +218,9 @@ bfa_fcs_vport_sm_fdisc(struct bfa_fcs_vport_s *vport,
 
        switch (event) {
        case BFA_FCS_VPORT_SM_DELETE:
-               bfa_sm_set_state(vport, bfa_fcs_vport_sm_logo);
+               bfa_sm_set_state(vport, bfa_fcs_vport_sm_cleanup);
                bfa_lps_discard(vport->lps);
-               bfa_fcs_vport_do_logo(vport);
+               bfa_fcs_port_delete(&vport->lport);
                break;
 
        case BFA_FCS_VPORT_SM_OFFLINE:
@@ -357,8 +357,9 @@ bfa_fcs_vport_sm_error(struct bfa_fcs_vport_s *vport,
 
        switch (event) {
        case BFA_FCS_VPORT_SM_DELETE:
-               bfa_sm_set_state(vport, bfa_fcs_vport_sm_uninit);
-               bfa_fcs_vport_free(vport);
+               bfa_sm_set_state(vport, bfa_fcs_vport_sm_cleanup);
+               bfa_fcs_port_delete(&vport->lport);
+
                break;
 
        default: