regulator: s2mps11: Use of_get_child_by_name
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 4 Mar 2014 05:46:57 +0000 (11:16 +0530)
committerMark Brown <broonie@linaro.org>
Wed, 19 Mar 2014 13:11:07 +0000 (13:11 +0000)
of_find_node_by_name walks the allnodes list, and can thus walk
outside of the parent node. Use of_get_child_by_name instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/s2mps11.c

index cdd8d40..906d764 100644 (file)
@@ -616,7 +616,7 @@ static int s2mps11_pmic_probe(struct platform_device *pdev)
        for (i = 0; i < s2mps11->rdev_num; i++)
                rdata[i].name = regulators[i].name;
 
-       reg_np = of_find_node_by_name(iodev->dev->of_node, "regulators");
+       reg_np = of_get_child_by_name(iodev->dev->of_node, "regulators");
        if (!reg_np) {
                dev_err(&pdev->dev, "could not find regulators sub-node\n");
                ret = -EINVAL;