[media] pvrusb2: check for allocation failures
authorDan Carpenter <error27@gmail.com>
Sat, 26 Mar 2011 01:52:22 +0000 (22:52 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 20 May 2011 12:28:24 +0000 (09:28 -0300)
This function returns NULL on failure so lets do that if kzalloc()
fails.  There is a separate problem that the caller for this function
doesn't check for errors...

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-By: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/pvrusb2/pvrusb2-std.c

index ca9f83a..35c8b40 100644 (file)
@@ -370,7 +370,11 @@ struct v4l2_standard *pvr2_std_create_enum(unsigned int *countptr,
 
        stddefs = kzalloc(sizeof(struct v4l2_standard) * std_cnt,
                          GFP_KERNEL);
-       for (idx = 0; idx < std_cnt; idx++) stddefs[idx].index = idx;
+       if (!stddefs)
+               return NULL;
+
+       for (idx = 0; idx < std_cnt; idx++)
+               stddefs[idx].index = idx;
 
        idx = 0;