tracing/selftest: Add a WARN_ON() if a tracer test fails
authorSteven Rostedt <srostedt@redhat.com>
Mon, 18 Jun 2012 13:28:16 +0000 (09:28 -0400)
committerSteven Rostedt <rostedt@goodmis.org>
Thu, 28 Jun 2012 17:52:14 +0000 (13:52 -0400)
Add a WARN_ON() output on test failures so that they are easier to detect
in automated tests. Although, the WARN_ON() will not print if the test
causes the system to crash, obviously.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace.c

index 49249c2..748f640 100644 (file)
@@ -830,6 +830,8 @@ int register_tracer(struct tracer *type)
                current_trace = saved_tracer;
                if (ret) {
                        printk(KERN_CONT "FAILED!\n");
+                       /* Add the warning after printing 'FAILED' */
+                       WARN_ON(1);
                        goto out;
                }
                /* Only reset on passing, to avoid touching corrupted buffers */