staging: brcm80211: remove CRC_INNER_LOOP macro
authorArend van Spriel <arend@broadcom.com>
Tue, 3 May 2011 09:35:55 +0000 (11:35 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 3 May 2011 19:42:46 +0000 (12:42 -0700)
With the removal of hndcrc16 and hndcrc32 this macro is not needed
anymore. Also the crc-ccitt library functions provide an equivalent
static inline function for this operation.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/brcm80211/util/bcmutils.c

index bcaf911..7337a75 100644 (file)
@@ -564,16 +564,11 @@ static const u8 crc8_table[256] = {
        0xF4, 0x03, 0x4D, 0xBA, 0xD1, 0x26, 0x68, 0x9F
 };
 
-#define CRC_INNER_LOOP(n, c, x) \
-       ((c) = ((c) >> 8) ^ crc##n##_table[((c) ^ (x)) & 0xff])
-
 u8 hndcrc8(u8 *pdata,  /* pointer to array of data to process */
                         uint nbytes,   /* number of input data bytes to process */
                         u8 crc /* either CRC8_INIT_VALUE or previous return value */
     ) {
-       /* hard code the crc loop instead of using CRC_INNER_LOOP macro
-        * to avoid the undefined and unnecessary (u8 >> 8) operation.
-        */
+       /* loop over the buffer data */
        while (nbytes-- > 0)
                crc = crc8_table[(crc ^ *pdata++) & 0xff];