git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
f0831ac
)
[PATCH] spufs: fix sparse warnings
author
Arnd Bergmann
<arnd@arndb.de>
Wed, 4 Jan 2006 19:31:31 +0000
(20:31 +0100)
committer
Paul Mackerras
<paulus@samba.org>
Mon, 9 Jan 2006 04:44:52 +0000
(15:44 +1100)
One local variable is missing an __iomem modifier,
in another place, we pass a completely unused argument
with a missing __user modifier.
Signed-off-by: Arnd Bergmann <arndb@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/platforms/cell/spu_base.c
patch
|
blob
|
history
arch/powerpc/platforms/cell/spufs/inode.c
patch
|
blob
|
history
arch/powerpc/platforms/cell/spufs/spufs.h
patch
|
blob
|
history
arch/powerpc/platforms/cell/spufs/syscalls.c
patch
|
blob
|
history
diff --git
a/arch/powerpc/platforms/cell/spu_base.c
b/arch/powerpc/platforms/cell/spu_base.c
index
081b3dc
..
7fe3fa3
100644
(file)
--- a/
arch/powerpc/platforms/cell/spu_base.c
+++ b/
arch/powerpc/platforms/cell/spu_base.c
@@
-357,7
+357,7
@@
static void spu_init_channels(struct spu *spu)
{ 0x17, 1, }, { 0x18, 0, }, { 0x19, 0, }, { 0x1b, 0, },
{ 0x1c, 1, }, { 0x1d, 0, }, { 0x1e, 1, },
};
{ 0x17, 1, }, { 0x18, 0, }, { 0x19, 0, }, { 0x1b, 0, },
{ 0x1c, 1, }, { 0x1d, 0, }, { 0x1e, 1, },
};
- struct spu_priv2 *priv2;
+ struct spu_priv2
__iomem
*priv2;
int i;
priv2 = spu->priv2;
int i;
priv2 = spu->priv2;
diff --git
a/arch/powerpc/platforms/cell/spufs/inode.c
b/arch/powerpc/platforms/cell/spufs/inode.c
index
687f80d
..
1f3507c
100644
(file)
--- a/
arch/powerpc/platforms/cell/spufs/inode.c
+++ b/
arch/powerpc/platforms/cell/spufs/inode.c
@@
-293,9
+293,8
@@
out:
static struct file_system_type spufs_type;
static struct file_system_type spufs_type;
-long
-spufs_create_thread(struct nameidata *nd, const char *name,
- unsigned int flags, mode_t mode)
+long spufs_create_thread(struct nameidata *nd,
+ unsigned int flags, mode_t mode)
{
struct dentry *dentry;
int ret;
{
struct dentry *dentry;
int ret;
diff --git
a/arch/powerpc/platforms/cell/spufs/spufs.h
b/arch/powerpc/platforms/cell/spufs/spufs.h
index
c715ed0
..
db2601f
100644
(file)
--- a/
arch/powerpc/platforms/cell/spufs/spufs.h
+++ b/
arch/powerpc/platforms/cell/spufs/spufs.h
@@
-101,7
+101,7
@@
extern struct tree_descr spufs_dir_contents[];
/* system call implementation */
long spufs_run_spu(struct file *file,
struct spu_context *ctx, u32 *npc, u32 *status);
/* system call implementation */
long spufs_run_spu(struct file *file,
struct spu_context *ctx, u32 *npc, u32 *status);
-long spufs_create_thread(struct nameidata *nd,
const char *name,
+long spufs_create_thread(struct nameidata *nd,
unsigned int flags, mode_t mode);
extern struct file_operations spufs_context_fops;
unsigned int flags, mode_t mode);
extern struct file_operations spufs_context_fops;
diff --git
a/arch/powerpc/platforms/cell/spufs/syscalls.c
b/arch/powerpc/platforms/cell/spufs/syscalls.c
index
0c2896a
..
d549aa7
100644
(file)
--- a/
arch/powerpc/platforms/cell/spufs/syscalls.c
+++ b/
arch/powerpc/platforms/cell/spufs/syscalls.c
@@
-85,7
+85,7
@@
asmlinkage long sys_spu_create(const char __user *pathname,
ret = path_lookup(tmp, LOOKUP_PARENT|
LOOKUP_OPEN|LOOKUP_CREATE, &nd);
if (!ret) {
ret = path_lookup(tmp, LOOKUP_PARENT|
LOOKUP_OPEN|LOOKUP_CREATE, &nd);
if (!ret) {
- ret = spufs_create_thread(&nd,
pathname,
flags, mode);
+ ret = spufs_create_thread(&nd, flags, mode);
path_release(&nd);
}
putname(tmp);
path_release(&nd);
}
putname(tmp);