summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
3633b04)
The return code of ccw_device_probe_console() is not properly handled. It
should only return a valid ccw device pointer or a error value converted by
ERR_PTR. Fix the console driver code to check with IS_ERR instead against
NULL.
Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
#include <linux/init.h>
#include <linux/console.h>
#include <linux/interrupt.h>
#include <linux/init.h>
#include <linux/console.h>
#include <linux/interrupt.h>
#include <linux/slab.h>
#include <linux/bootmem.h>
#include <linux/slab.h>
#include <linux/bootmem.h>
}
cdev = ccw_device_probe_console();
}
cdev = ccw_device_probe_console();
return -ENODEV;
raw3215[0] = raw = (struct raw3215_info *)
return -ENODEV;
raw3215[0] = raw = (struct raw3215_info *)
#include <linux/interrupt.h>
#include <linux/list.h>
#include <linux/types.h>
#include <linux/interrupt.h>
#include <linux/list.h>
#include <linux/types.h>
#include <asm/ccwdev.h>
#include <asm/cio.h>
#include <asm/ccwdev.h>
#include <asm/cio.h>
}
cdev = ccw_device_probe_console();
}
cdev = ccw_device_probe_console();
return -ENODEV;
rp = raw3270_setup_console(cdev);
if (IS_ERR(rp))
return -ENODEV;
rp = raw3270_setup_console(cdev);
if (IS_ERR(rp))
int ret;
if (xchg(&console_cdev_in_use, 1) != 0)
int ret;
if (xchg(&console_cdev_in_use, 1) != 0)
+ return ERR_PTR(-EBUSY);
sch = cio_probe_console();
if (IS_ERR(sch)) {
console_cdev_in_use = 0;
sch = cio_probe_console();
if (IS_ERR(sch)) {
console_cdev_in_use = 0;