staging/wlan-ng: Fix 'Branch condition evaluates to a garbage value' in p80211netdev.c
authorPeter Huewe <peterhuewe@gmx.de>
Thu, 14 Feb 2013 02:37:10 +0000 (03:37 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Feb 2013 17:26:23 +0000 (09:26 -0800)
commitfae7e4d39373305cf505d1f0871a4491897d56f9
treea5a470d46528c6d0b9508adcb19eae2bca7a0735
parent0bcc0429bdb9f7cca3b7ab1f905b0d47031c03e0
staging/wlan-ng: Fix 'Branch condition evaluates to a garbage value' in p80211netdev.c

clang/scan-build complains that:
p80211netdev.c:451:6: warning: Branch condition evaluates to a garbage
value
        if ((p80211_wep.data) && (p80211_wep.data != skb->data))
            ^~~~~~~~~~~~~~~~~

This can happen in p80211knetdev_hard_start_xmit if
- if (wlandev->state != WLAN_DEVICE_OPEN) evaluates to true.
the execution flow then continues at the 'failed' label where
p80211_wep.data is used without being initialized first.

-> Initialize the data field to NULL to fix this issue.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/p80211netdev.c