tracing: Fix possible NULL pointer dereferences
authorNamhyung Kim <namhyung.kim@lge.com>
Thu, 11 Apr 2013 06:55:01 +0000 (15:55 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 25 Apr 2013 19:25:38 +0000 (20:25 +0100)
commitee3c9aabb636fcfc21d53c506362620b55fdd8c6
tree6335ad7e7bdbb51d61163ff5c73c8eef06f48396
parent2ee3a5e3ebce82a5ad4b36ac654be9347b7013ac
tracing: Fix possible NULL pointer dereferences

commit 6a76f8c0ab19f215af2a3442870eeb5f0e81998d upstream.

Currently set_ftrace_pid and set_graph_function files use seq_lseek
for their fops.  However seq_open() is called only for FMODE_READ in
the fops->open() so that if an user tries to seek one of those file
when she open it for writing, it sees NULL seq_file and then panic.

It can be easily reproduced with following command:

  $ cd /sys/kernel/debug/tracing
  $ echo 1234 | sudo tee -a set_ftrace_pid

In this example, GNU coreutils' tee opens the file with fopen(, "a")
and then the fopen() internally calls lseek().

Link: http://lkml.kernel.org/r/1365663302-2170-1-git-send-email-namhyung@kernel.org
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
[bwh: Backported to 3.2: ftrace_regex_lseek() is static]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/trace/ftrace.c