staging/bcm: integer underflow leads to Oom
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 17 Feb 2014 19:57:31 +0000 (22:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Feb 2014 19:18:10 +0000 (11:18 -0800)
commitee2104ea865f8a12eebb382aa502f248e14a5a2d
treecde6b73b7055b23532ab124101ada52a0fa5bf77
parentcfff3e5c8d2139c38d40d90e3d9fc13721222076
staging/bcm: integer underflow leads to Oom

We do:

        if (NOB > DEFAULT_BUFF_SIZE)
                BuffSize = DEFAULT_BUFF_SIZE;
        else
                BuffSize = NOB;

Since NOB can be negative it results in a larger than intended BuffSize
and makes kzalloc() fail.

The code is still a bit crap because it lets the users read as much as
they want from nvram, but I don't know what a sensible upper limit
should be.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/bcm/Bcmchar.c