e1000: fix vlan processing regression
authorJiri Pirko <jpirko@redhat.com>
Tue, 20 Mar 2012 18:10:01 +0000 (18:10 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 30 Oct 2012 23:26:29 +0000 (23:26 +0000)
commite48980d0eff084cc9ec51df85d655739c235668d
treeec158d04a96193ef1e3abb4deb5644a615982df9
parent810352f7bc7ee8788c89660bec3b7790e1c215bc
e1000: fix vlan processing regression

commit 52f5509fe8ccb607ff9b84ad618f244262336475 upstream.

This patch fixes a regression introduced by commit "e1000: do vlan
cleanup (799d531)".

Apparently some e1000 chips (not mine) are sensitive about the order of
setting vlan filter and vlan stripping/inserting functionality. So this
patch changes the order so it's the same as before vlan cleanup.

Reported-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Tested-by: Ben Greear <greearb@candelatech.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
[Jonathan Nieder: It doesn't apply cleanly to kernels before
v3.3-rc1~182^2~581 (net: introduce and use netdev_features_t for
device features sets) but a backport is straightforward.]
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Tested-by: Andrey Jr. Melnikov <temnota@kmv.ru>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/ethernet/intel/e1000/e1000_main.c