git.openpandora.org / pandora-kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3bfd058) | patch
Staging: comedi: Correct use of ! and &
authorJulia Lawall <julia@diku.dk>
Wed, 24 Dec 2008 15:23:10 +0000 (16:23 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 3 Apr 2009 21:53:40 +0000 (14:53 -0700)
commitd86d3a0101d958988a715abb7ea4687690f0b52f
treeb6c5788468614c1cb17e2d25a9e8a6d31d989817tree | snapshot
parent3bfd0583639a292da151fba7321d6fe5bd40f50dcommit | diff
Staging: comedi: Correct use of ! and &

0x20 has 0 as its rightmost bit and thus !inl(info->plx_regbase +
PLX_INTCSR) & 0x20 is always 0.  I assume that !(!inl(info->plx_regbase +
PLX_INTCSR) & 0x20) was intended.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
(
  !E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/comedi/drivers/me4000.c diff | blob | history
Pandora Kernel Repository