scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND
authorJan Kara <jack@suse.cz>
Thu, 23 Oct 2014 02:13:39 +0000 (20:13 -0600)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 14 Dec 2014 16:23:50 +0000 (16:23 +0000)
commitd73b032b63e8967462e1cf5763858ed89e97880f
tree491025d55c0276ff899d72283cc459b21ce61f2a
parent50a977230b76989c275125016c32e536921c7f75
scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND

commit 84ce0f0e94ac97217398b3b69c21c7a62ebeed05 upstream.

When sg_scsi_ioctl() fails to prepare request to submit in
blk_rq_map_kern() we jump to a label where we just end up copying
(luckily zeroed-out) kernel buffer to userspace instead of reporting
error. Fix the problem by jumping to the right label.

CC: Jens Axboe <axboe@kernel.dk>
CC: linux-scsi@vger.kernel.org
Coverity-id: 1226871
Signed-off-by: Jan Kara <jack@suse.cz>
Fixed up the, now unused, out label.

Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
block/scsi_ioctl.c