isci: fix isci_pci_probe() generates warning on efi failure path
authorDan Williams <dan.j.williams@intel.com>
Fri, 22 Jun 2012 18:31:14 +0000 (11:31 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 17 Oct 2012 02:34:07 +0000 (03:34 +0100)
commitd562efad2326a7c2383a211f41d0d4121fad5d4b
tree7b8d8f7cece437cbccb4cdfa5766b660bd8c57f3
parenta2b4bcbfbe576b87372f1af36d4fb1d31ae2bd92
isci: fix isci_pci_probe() generates warning on efi failure path

commit 6d70a74ffd616073a68ae0974d98819bfa8e6da6 upstream.

The oem parameter image embedded in the efi variable is at an offset
from the start of the variable.  However, in the failure path we try to
free the 'orom' pointer which is only valid when the paramaters are
being read from the legacy option-rom space.

Since failure to load the oem parameters is unlikely and we keep the
memory around in the success case just defer all de-allocation to devm.

Reported-by: Don Morris <don.morris@hp.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/scsi/isci/init.c
drivers/scsi/isci/probe_roms.c