USB: Proper handling of Race Condition when two USB class drivers try to call init_us...
authorAjay Kaher <ajay.kaher@samsung.com>
Tue, 28 Mar 2017 12:09:32 +0000 (08:09 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Aug 2017 01:13:58 +0000 (02:13 +0100)
commitd3104d983465e23fb059cd32d34e8e35a8860fd2
tree7250d68ebd7ec42ea56405463463207f06098013
parent57635e471138a0a1080e1001da4581d182c06d85
USB: Proper handling of Race Condition when two USB class drivers try to call init_usb_class simultaneously

commit 2f86a96be0ccb1302b7eee7855dbee5ce4dc5dfb upstream.

There is race condition when two USB class drivers try to call
init_usb_class at the same time and leads to crash.
code path: probe->usb_register_dev->init_usb_class

To solve this, mutex locking has been added in init_usb_class() and
destroy_usb_class().

As pointed by Alan, removed "if (usb_class)" test from destroy_usb_class()
because usb_class can never be NULL there.

Signed-off-by: Ajay Kaher <ajay.kaher@samsung.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/core/file.c