net: disallow drivers with buggy VLAN accel to register_netdevice()
authorMichał Mirosław <mirq-linux@rere.qmqm.pl>
Tue, 29 Jan 2013 15:14:16 +0000 (15:14 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Jan 2013 03:58:40 +0000 (22:58 -0500)
commitd2ed273d30c5ffd14f6b5ec7ecc751d960f832fc
tree3a127f68981cd7536303fb111ee2668af44003e9
parent29e3b1608c8dca3ae4224a26862d18ea003ccee6
net: disallow drivers with buggy VLAN accel to register_netdevice()

Instead of jumping aroung bugs that are easily fixed just don't let them in:
affected drivers should be either fixed or have NETIF_F_HW_VLAN_FILTER
removed from advertised features.

Quick grep in drivers/net shows two drivers that have NETIF_F_HW_VLAN_FILTER
but not ndo_vlan_rx_add/kill_vid(), but those are false-positives (features
are commented out).

OTOH two drivers have ndo_vlan_rx_add/kill_vid() implemented but don't
advertise NETIF_F_HW_VLAN_FILTER. Those are:

+ethernet/cisco/enic/enic_main.c
+ethernet/qlogic/qlcnic/qlcnic_main.c

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/8021q/vlan.c
net/8021q/vlan_core.c
net/core/dev.c